Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2468923002: [inspector_protocol] support fall through and moveable Maybe (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[inspector_protocol] support fall through and moveable Maybe Based on: - https://codereview.chromium.org/2463673004/ (support fall through) - https://codereview.chromium.org/2463293002/ (moveable Maybe) BUG=none R=dgozman@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocolcf45a6e89b17cdc9eeacdef4c003fcc55f7ec2a0

Patch Set 1 #

Patch Set 2 : moveable Maybe #

Patch Set 3 : added missing std::move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -126 lines) Patch
M CodeGenerator.py View 1 4 chunks +7 lines, -2 lines 0 comments Download
M inspector_protocol.gni View 1 chunk +0 lines, -1 line 0 comments Download
M inspector_protocol.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D lib/BackendCallback_h.template View 1 chunk +0 lines, -24 lines 0 comments Download
M lib/DispatcherBase_cpp.template View 6 chunks +82 lines, -30 lines 0 comments Download
M lib/DispatcherBase_h.template View 5 chunks +42 lines, -19 lines 0 comments Download
M lib/Forward_h.template View 1 chunk +2 lines, -0 lines 0 comments Download
M lib/Maybe_h.template View 1 6 chunks +6 lines, -0 lines 0 comments Download
M templates/TypeBuilder_cpp.template View 1 2 7 chunks +71 lines, -34 lines 0 comments Download
M templates/TypeBuilder_h.template View 1 3 chunks +55 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kozy
Dmitry, please take a look!
4 years, 1 month ago (2016-11-01 15:14:12 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-01 18:08:53 UTC) #2
kozy
4 years, 1 month ago (2016-11-01 18:15:53 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
cf45a6e89b17cdc9eeacdef4c003fcc55f7ec2a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698