Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Unified Diff: templates/TypeBuilder_h.template

Issue 2473393002: Add missing virtual destructor to backend callbacks. (Closed)
Patch Set: Intendation fix. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: templates/TypeBuilder_h.template
diff --git a/templates/TypeBuilder_h.template b/templates/TypeBuilder_h.template
index 1d5a57bdc308923774d0f34d34a635f8f60d5712..f665039dd7da19ea76c68b595b2929ff8f33cbe4 100644
--- a/templates/TypeBuilder_h.template
+++ b/templates/TypeBuilder_h.template
@@ -204,6 +204,7 @@ public:
{%- endfor -%}
) = 0;
virtual void sendFailure(const DispatchResponse&) = 0;
+ virtual ~{{command.name | to_title_case}}Callback() { }
};
{% endif %}
{%- if not("async" in command) %}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698