[headless] Refactor headless devtools client API.

[headless] Refactor headless devtools client API.

This patch splits types.{h,cc} and type_conversions.h into multiple
files on per-domain basis. This makes them more readable and reduces
compilation times.

Aliases are avalaible at the old locations for the transition period.

BUG=546953
Committed: https://crrev.com/eaffa8e0c53f3c61a9239b27295b390884bd5fd5
Cr-Commit-Position: refs/heads/master@{#430774}

[altimin, 2016-11-03 18:46:45]

altimin@chromium.org changed reviewers:
+ skyostil@chromium.org

[altimin, 2016-11-03 18:46:46]

PTAL

[Sami, 2016-11-04 17:42:10]

Looks like a great cleanup! Would you also mind updating all the code under
headless/ to the new scheme?

https://codereview.chromium.org/2473073003/diff/20001/headless/BUILD.gn
File headless/BUILD.gn (right):

https://codereview.chromium.org/2473073003/diff/20001/headless/BUILD.gn#newco...
headless/BUILD.gn:106:
"$target_gen_dir/public/devtools/internal/type_conversions" + domain + ".h",
Missing underscore before the quote?

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
File headless/lib/browser/devtools_api/client_api_generator.py (right):

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/client_api_generator.py:367: def
InitializeDependencies(json_api):
nit: InitializeDomainDependencies to be a little more explicit.

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/client_api_generator.py:427: This guarantees
API compatibility if a previously experimental command is made
Line too long or Rietvelt being confused?

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/client_api_generator.py:493: # Generate
forward declarations for types
nit: missing '.'

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/client_api_generator.py:498: # Generate types
on per-domain basis
nit: missing '.'

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
File headless/lib/browser/devtools_api/deprecated_domain_h.template (right):

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/deprecated_domain_h.template:3: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
nit: old-style copyright header.

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
File headless/lib/browser/devtools_api/deprecated_type_conversions_h.template
(right):

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/deprecated_type_conversions_h.template:7:
#ifndef HEADLESS_PUBLIC_DOMAINS_TYPE_CONVERSIONS_H_
Missing DEVTOOLS

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
File headless/lib/browser/devtools_api/deprecated_types_h.template (right):

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/deprecated_types_h.template:3: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
nit: old-style copyright header.

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/deprecated_types_h.template:7: #ifndef
HEADLESS_PUBLIC_DOMAINS_TYPES_H_
DEVTOOLS

[altimin, 2016-11-08 17:14:19]

PTAL

https://codereview.chromium.org/2473073003/diff/20001/headless/BUILD.gn
File headless/BUILD.gn (right):

https://codereview.chromium.org/2473073003/diff/20001/headless/BUILD.gn#newco...
headless/BUILD.gn:106:
"$target_gen_dir/public/devtools/internal/type_conversions" + domain + ".h",
On 2016/11/04 17:42:10, Sami wrote:
> Missing underscore before the quote?

Done.

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
File headless/lib/browser/devtools_api/client_api_generator.py (right):

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/client_api_generator.py:367: def
InitializeDependencies(json_api):
On 2016/11/04 17:42:10, Sami wrote:
> nit: InitializeDomainDependencies to be a little more explicit.

Done.

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/client_api_generator.py:427: This guarantees
API compatibility if a previously experimental command is made
On 2016/11/04 17:42:10, Sami wrote:
> Line too long or Rietvelt being confused?

It's exactly 80 chars long.

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/client_api_generator.py:493: # Generate
forward declarations for types
On 2016/11/04 17:42:10, Sami wrote:
> nit: missing '.'

Done.

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/client_api_generator.py:498: # Generate types
on per-domain basis
On 2016/11/04 17:42:10, Sami wrote:
> nit: missing '.'

Done.

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
File headless/lib/browser/devtools_api/deprecated_domain_h.template (right):

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/deprecated_domain_h.template:3: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
On 2016/11/04 17:42:10, Sami wrote:
> nit: old-style copyright header.

Done.

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
File headless/lib/browser/devtools_api/deprecated_type_conversions_h.template
(right):

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/deprecated_type_conversions_h.template:7:
#ifndef HEADLESS_PUBLIC_DOMAINS_TYPE_CONVERSIONS_H_
On 2016/11/04 17:42:10, Sami wrote:
> Missing DEVTOOLS

No, this header lives at the old location for backwards-compatibility.

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
File headless/lib/browser/devtools_api/deprecated_types_h.template (right):

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/deprecated_types_h.template:3: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
On 2016/11/04 17:42:10, Sami wrote:
> nit: old-style copyright header.

Done.

https://codereview.chromium.org/2473073003/diff/20001/headless/lib/browser/de...
headless/lib/browser/devtools_api/deprecated_types_h.template:7: #ifndef
HEADLESS_PUBLIC_DOMAINS_TYPES_H_
On 2016/11/04 17:42:10, Sami wrote:
> DEVTOOLS

Nope.

[Sami, 2016-11-08 18:58:44]

Thanks, lgtm with one nit.

https://codereview.chromium.org/2473073003/diff/40001/headless/public/domains...
File headless/public/domains/types_unittest.cc (right):

https://codereview.chromium.org/2473073003/diff/40001/headless/public/domains...
headless/public/domains/types_unittest.cc:6: #include
"headless/public/domains/types.h"  // TODO(altimin): Remove it.
Could we replace these with the individual ones this test needs?

[Sami, 2016-11-08 18:59:06]

Btw the headless tryjob I submitted was unhappy with this patch. Might want to
check that before landing.

[altimin, 2016-11-08 19:14:44]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 19:15:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2016-11-08 19:15:18]

The CQ bit was unchecked by altimin@chromium.org

[altimin, 2016-11-08 19:16:19]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 19:16:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2016-11-08 19:16:58]

https://codereview.chromium.org/2473073003/diff/40001/headless/public/domains...
File headless/public/domains/types_unittest.cc (right):

https://codereview.chromium.org/2473073003/diff/40001/headless/public/domains...
headless/public/domains/types_unittest.cc:6: #include
"headless/public/domains/types.h"  // TODO(altimin): Remove it.
On 2016/11/08 18:58:44, Sami wrote:
> Could we replace these with the individual ones this test needs?

Done.

[altimin, 2016-11-08 19:18:52]

altimin@chromium.org changed reviewers:
+ dpranke@chromium.org

[altimin, 2016-11-08 19:18:52]

+ dpranke@: Please approve changes in testing script.

[commit-bot: I haz the power, 2016-11-08 21:00:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 21:00:13]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-11-08 21:12:58]

lgtm

[altimin, 2016-11-08 23:49:01]

The CQ bit was checked by altimin@chromium.org

[altimin, 2016-11-08 23:49:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2473073003/#ps60001
(title: "Address nits")

[commit-bot: I haz the power, 2016-11-08 23:49:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 23:57:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-09 00:04:58]

Description was changed from

==========
[headless] Refactor headless devtools client API.

This patch splits types.{h,cc} and type_conversions.h into multiple
files on per-domain basis. This makes them more readable and reduces
compilation times.

Aliases are avalaible at the old locations for the transition period.

BUG=546953
==========

to

==========
[headless] Refactor headless devtools client API.

This patch splits types.{h,cc} and type_conversions.h into multiple
files on per-domain basis. This makes them more readable and reduces
compilation times.

Aliases are avalaible at the old locations for the transition period.

BUG=546953

Committed: https://crrev.com/eaffa8e0c53f3c61a9239b27295b390884bd5fd5
Cr-Commit-Position: refs/heads/master@{#430774}
==========

[commit-bot: I haz the power, 2016-11-09 00:04:59]

Patchset 4 (id:??) landed as
https://crrev.com/eaffa8e0c53f3c61a9239b27295b390884bd5fd5
Cr-Commit-Position: refs/heads/master@{#430774}