headless/lib/headless_browser_browsertest.cc - Issue 2473073003: [headless] Refactor headless devtools client API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: headless/lib/headless_browser_browsertest.cc

Issue 2473073003: [headless] Refactor headless devtools client API. (Closed)

Patch Set: Address nits Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « headless/lib/embedder_mojo_browsertest.cc ('k') | headless/lib/headless_devtools_client_browsertest.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <memory>	5 #include <memory>

6	6

7 #include "base/command_line.h"	7 #include "base/command_line.h"

8 #include "base/files/file_util.h"	8 #include "base/files/file_util.h"

9 #include "base/memory/ptr_util.h"	9 #include "base/memory/ptr_util.h"

10 #include "base/strings/stringprintf.h"	10 #include "base/strings/stringprintf.h"

11 #include "base/threading/thread_restrictions.h"	11 #include "base/threading/thread_restrictions.h"

12 #include "content/public/test/browser_test.h"	12 #include "content/public/test/browser_test.h"

13 #include "headless/public/domains/network.h"	13 #include "headless/public/devtools/domains/network.h"

14 #include "headless/public/domains/page.h"	14 #include "headless/public/devtools/domains/page.h"

15 #include "headless/public/headless_browser.h"	15 #include "headless/public/headless_browser.h"

16 #include "headless/public/headless_devtools_client.h"	16 #include "headless/public/headless_devtools_client.h"

17 #include "headless/public/headless_devtools_target.h"	17 #include "headless/public/headless_devtools_target.h"

18 #include "headless/public/headless_web_contents.h"	18 #include "headless/public/headless_web_contents.h"

19 #include "headless/test/headless_browser_test.h"	19 #include "headless/test/headless_browser_test.h"

20 #include "headless/test/test_protocol_handler.h"	20 #include "headless/test/test_protocol_handler.h"

21 #include "headless/test/test_url_request_job.h"	21 #include "headless/test/test_url_request_job.h"

22 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"	22 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"

23 #include "net/cookies/cookie_store.h"	23 #include "net/cookies/cookie_store.h"

24 #include "net/test/spawned_test_server/spawned_test_server.h"	24 #include "net/test/spawned_test_server/spawned_test_server.h"

(...skipping 611 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
636 // Make sure the launcher was invoked when starting the renderer.	636 // Make sure the launcher was invoked when starting the renderer.

637 std::string stamp;	637 std::string stamp;

638 EXPECT_TRUE(base::ReadFileToString(launcher_stamp, &stamp));	638 EXPECT_TRUE(base::ReadFileToString(launcher_stamp, &stamp));

639 EXPECT_GE(stamp.find("--type=renderer"), 0u);	639 EXPECT_GE(stamp.find("--type=renderer"), 0u);

640	640

641 base::DeleteFile(launcher_script, false);	641 base::DeleteFile(launcher_script, false);

642 base::DeleteFile(launcher_stamp, false);	642 base::DeleteFile(launcher_stamp, false);

643 }	643 }

644	644

645 } // namespace headless	645 } // namespace headless

OLD	NEW