Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: headless/lib/browser/type_conversions_h.template

Issue 2473073003: [headless] Refactor headless devtools client API. (Closed)
Patch Set: Address nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/headless_devtools_manager_delegate.cc ('k') | headless/lib/browser/types_cc.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/type_conversions_h.template
diff --git a/headless/lib/browser/type_conversions_h.template b/headless/lib/browser/type_conversions_h.template
deleted file mode 100644
index 1c918ac9ea3f138223957684314682c830ada722..0000000000000000000000000000000000000000
--- a/headless/lib/browser/type_conversions_h.template
+++ /dev/null
@@ -1,77 +0,0 @@
-// This file is generated
-
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef HEADLESS_PUBLIC_DOMAINS_TYPE_CONVERSIONS_H_
-#define HEADLESS_PUBLIC_DOMAINS_TYPE_CONVERSIONS_H_
-
-#include "headless/public/domains/types.h"
-#include "headless/public/internal/value_conversions.h"
-
-namespace headless {
-namespace internal {
-
-{% for domain in api.domains %}
- {% for type in domain.types %}
- {% set namespace = domain.domain | camelcase_to_hacker_style %}
- {% if "enum" in type %}
-template <>
-struct FromValue<{{namespace}}::{{type.id}}> {
- static {{namespace}}::{{type.id}} Parse(const base::Value& value, ErrorReporter* errors) {
- {% set default = namespace + '::' + type.id + '::' + type.enum[0] | sanitize_literal | dash_to_camelcase | camelcase_to_hacker_style | upper %}
- std::string string_value;
- if (!value.GetAsString(&string_value)) {
- errors->AddError("string enum value expected");
- {# Return an arbitrary enum member -- the caller will just ignore it. #}
- return {{default}};
- }
- {% for literal in type.enum %}
- if (string_value == "{{literal}}")
- return {{namespace}}::{{type.id}}::{{literal | sanitize_literal | dash_to_camelcase | camelcase_to_hacker_style | upper }};
- {% endfor %}
- errors->AddError("invalid enum value");
- return {{default}};
- }
-};
-
-template <typename T>
-std::unique_ptr<base::Value> ToValueImpl(const {{namespace}}::{{type.id}}& value, T*) {
- switch (value) {
- {% for literal in type.enum %}
- case {{namespace}}::{{type.id}}::{{literal | sanitize_literal | dash_to_camelcase | camelcase_to_hacker_style | upper }}:
- return base::WrapUnique(new base::StringValue("{{literal}}"));
- {% endfor %}
- };
- NOTREACHED();
- return nullptr;
-}
- {% continue %}
- {% endif %}
-
- {% if not (type.type == "object") or not ("properties" in type) %}{% continue %}{% endif %}
-template <>
-struct FromValue<{{namespace}}::{{type.id}}> {
- static std::unique_ptr<{{namespace}}::{{type.id}}> Parse(const base::Value& value, ErrorReporter* errors) {
- return {{namespace}}::{{type.id}}::Parse(value, errors);
- }
-};
-
-template <typename T>
-std::unique_ptr<base::Value> ToValueImpl(const {{namespace}}::{{type.id}}& value, T*) {
- return value.Serialize();
-}
-
- {% endfor %}
-{% endfor %}
-
-template <typename T>
-std::unique_ptr<base::Value> ToValue(const T& value) {
- return ToValueImpl(value, static_cast<T*>(nullptr));
-}
-
-} // namespace internal
-} // namespace headless
-
-#endif // HEADLESS_PUBLIC_DOMAINS_TYPE_CONVERSIONS_H_
« no previous file with comments | « headless/lib/browser/headless_devtools_manager_delegate.cc ('k') | headless/lib/browser/types_cc.template » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698