content: Cleanup class/struct forward declarations

content: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in content header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/ed975026c4f67a57d5721024e4e9cc8a2b1ff3ae
Cr-Commit-Position: refs/heads/master@{#429839}

[jbriance, 2016-11-03 12:39:53]

Description was changed from

==========
content: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in content header files.

BUG=none
==========

to

==========
content: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in content header files.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jbriance, 2016-11-03 12:43:02]

jbriance@cisco.com changed reviewers:
+ avi@chromium.org, jochen@chromium.org, pfeldman@chromium.org

[jbriance, 2016-11-03 12:43:04]

Following what I did in blink (https://codereview.chromium.org/2460243002/,
https://codereview.chromium.org/2463703003/ and
https://codereview.chromium.org/2466383004/), remove unused forward class and
struct declarations in content header files.

As I don't know the appropriate reviewers to target here, please feel free to
add/remove reviewers.

[Avi (use Gerrit), 2016-11-03 14:38:28]

lgtm

[jbriance, 2016-11-03 14:39:56]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 14:40:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 14:53:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 14:53:51]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbriance, 2016-11-03 16:32:46]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 16:33:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 16:56:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 16:56:22]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbriance, 2016-11-03 17:21:05]

The CQ bit was checked by jbriance@cisco.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 17:21:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 21:15:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 21:15:21]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jbriance, 2016-11-03 21:16:44]

The CQ bit was checked by jbriance@cisco.com

[jbriance, 2016-11-03 21:16:45]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/2473003002/#ps40001
(title: "Another missing forward declaration")

[commit-bot: I haz the power, 2016-11-03 21:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 21:41:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 21:41:08]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nico, 2016-11-03 21:43:17]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-11-03 21:43:18]

If you're doing something that spans more than one change, please always file a
tracking bug for that and mention it from all the CLs. The bug would also be a
good place to attach the script you use to generate the patches – reviewing the
script is probably much faster than reviewing the patch :-)

Having said that, thanks for doing this, and rs-lgtm.

[jbriance, 2016-11-03 22:12:56]

Description was changed from

==========
content: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in content header files.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
content: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in content header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jbriance, 2016-11-03 22:17:59]

On 2016/11/03 21:43:18, Nico (mostly afk Wed-Fri) wrote:
> If you're doing something that spans more than one change, please always file
a
> tracking bug for that and mention it from all the CLs. The bug would also be a
> good place to attach the script you use to generate the patches
– reviewing the
> script is probably much faster than reviewing the patch :-)

Done: https://bugs.chromium.org/p/chromium/issues/detail?id=662195

[jbriance, 2016-11-03 22:21:54]

jbriance@cisco.com changed reviewers:
+ dcheng@chromium.org, halliwell@chromium.org
- pfeldman@chromium.org

[jbriance, 2016-11-03 22:21:56]

+ halliwell for chromecast/ changes and dcheng for
content/common/*_param_traits.h changes

[dcheng, 2016-11-03 22:23:25]

ipc lgtm

[halliwell, 2016-11-03 22:29:40]

On 2016/11/03 22:23:25, dcheng wrote:
> ipc lgtm

chromecast/ lgtm

[Fady Samuel, 2016-11-03 22:33:14]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2016-11-03 22:33:16]

guest_view lgtm

[jbriance, 2016-11-03 22:34:15]

The CQ bit was checked by jbriance@cisco.com

[commit-bot: I haz the power, 2016-11-03 22:35:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 01:27:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 01:27:44]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jbriance, 2016-11-04 07:01:34]

The CQ bit was checked by jbriance@cisco.com

[commit-bot: I haz the power, 2016-11-04 07:01:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 09:14:54]

Description was changed from

==========
content: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in content header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
content: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in content header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-11-04 09:14:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-04 09:16:52]

Description was changed from

==========
content: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in content header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
content: Cleanup class/struct forward declarations

Remove useless class and struct forward declarations, and add
missing ones in content header files.

BUG=662195
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/ed975026c4f67a57d5721024e4e9cc8a2b1ff3ae
Cr-Commit-Position: refs/heads/master@{#429839}
==========

[commit-bot: I haz the power, 2016-11-04 09:16:56]

Patchset 3 (id:??) landed as
https://crrev.com/ed975026c4f67a57d5721024e4e9cc8a2b1ff3ae
Cr-Commit-Position: refs/heads/master@{#429839}