Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issue 2472583006: Add support of leader_point in NGLayoutOpportunityIterator. (Closed)

Created:
4 years, 1 month ago by Gleb Lanbin
Modified:
4 years, 1 month ago
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support of leader_point in NGLayoutOpportunityIterator. Leader point together with origin_point creates a temporary exclusion that should be avoided in the layout opportunity iterator. BUG=635619 Committed: https://crrev.com/2e09ff76918cbd153161b9ab1062e690eb67d3ab Cr-Commit-Position: refs/heads/master@{#429650}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update ToLeaderExclusion #

Total comments: 2

Patch Set 3 : LayoutUnit(0) -> LayoutUnit() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -17 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 1 3 chunks +38 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.h View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.cc View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Gleb Lanbin
4 years, 1 month ago (2016-11-02 23:22:14 UTC) #2
atotic
https://codereview.chromium.org/2472583006/diff/1/third_party/WebKit/Source/core/layout/ng/ng_units.h File third_party/WebKit/Source/core/layout/ng/ng_units.h (right): https://codereview.chromium.org/2472583006/diff/1/third_party/WebKit/Source/core/layout/ng/ng_units.h#newcode32 third_party/WebKit/Source/core/layout/ng/ng_units.h:32: return inline_size == LayoutUnit(0) || block_size == LayoutUnit(0); Suggestion: ...
4 years, 1 month ago (2016-11-02 23:33:37 UTC) #4
Gleb Lanbin
thanks for the review. https://codereview.chromium.org/2472583006/diff/1/third_party/WebKit/Source/core/layout/ng/ng_units.h File third_party/WebKit/Source/core/layout/ng/ng_units.h (right): https://codereview.chromium.org/2472583006/diff/1/third_party/WebKit/Source/core/layout/ng/ng_units.h#newcode32 third_party/WebKit/Source/core/layout/ng/ng_units.h:32: return inline_size == LayoutUnit(0) || ...
4 years, 1 month ago (2016-11-02 23:46:47 UTC) #5
cbiesinger
https://codereview.chromium.org/2472583006/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_units.h File third_party/WebKit/Source/core/layout/ng/ng_units.h (right): https://codereview.chromium.org/2472583006/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_units.h#newcode32 third_party/WebKit/Source/core/layout/ng/ng_units.h:32: return inline_size == LayoutUnit(0) || block_size == LayoutUnit(0); Use ...
4 years, 1 month ago (2016-11-03 15:00:40 UTC) #7
ikilpatrick
lgtm
4 years, 1 month ago (2016-11-03 15:31:54 UTC) #8
Gleb Lanbin
https://codereview.chromium.org/2472583006/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_units.h File third_party/WebKit/Source/core/layout/ng/ng_units.h (right): https://codereview.chromium.org/2472583006/diff/20001/third_party/WebKit/Source/core/layout/ng/ng_units.h#newcode32 third_party/WebKit/Source/core/layout/ng/ng_units.h:32: return inline_size == LayoutUnit(0) || block_size == LayoutUnit(0); On ...
4 years, 1 month ago (2016-11-03 16:13:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2472583006/40001
4 years, 1 month ago (2016-11-03 18:08:11 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-03 18:18:43 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2e09ff76918cbd153161b9ab1062e690eb67d3ab Cr-Commit-Position: refs/heads/master@{#429650}
4 years, 1 month ago (2016-11-03 18:45:24 UTC) #19
Mathieu
4 years, 1 month ago (2016-11-03 19:29:15 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2477843002/ by mathp@chromium.org.

The reason for reverting is: Causing a failure on Mac MSAN:

https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests....

Powered by Google App Engine
This is Rietveld 408576698