Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2477843002: Revert of Add support of leader_point in NGLayoutOpportunityIterator. (Closed)

Created:
4 years, 1 month ago by Mathieu
Modified:
4 years, 1 month ago
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support of leader_point in NGLayoutOpportunityIterator. (patchset #3 id:40001 of https://codereview.chromium.org/2472583006/ ) Reason for revert: Causing a failure on Mac MSAN: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/23812 Original issue's description: > Add support of leader_point in NGLayoutOpportunityIterator. > > Leader point together with origin_point creates a temporary exclusion that should be avoided in the layout opportunity iterator. > > BUG=635619 > > Committed: https://crrev.com/2e09ff76918cbd153161b9ab1062e690eb67d3ab > Cr-Commit-Position: refs/heads/master@{#429650} TBR=ikilpatrick@chromium.org,atotic@chromium.org,cbiesinger@chromium.org,glebl@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619 Committed: https://crrev.com/26c7e1870906e9af248b2b323dc68d6f6d5a9187 Cr-Commit-Position: refs/heads/master@{#429672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -92 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 3 chunks +3 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.h View 2 chunks +1 line, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mathieu
Created Revert of Add support of leader_point in NGLayoutOpportunityIterator.
4 years, 1 month ago (2016-11-03 19:29:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477843002/1
4 years, 1 month ago (2016-11-03 19:29:59 UTC) #3
Gleb Lanbin
LGTM, thanks.
4 years, 1 month ago (2016-11-03 19:32:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 19:33:56 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 19:46:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26c7e1870906e9af248b2b323dc68d6f6d5a9187
Cr-Commit-Position: refs/heads/master@{#429672}

Powered by Google App Engine
This is Rietveld 408576698