third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h - Issue 2472583006: Add support of leader_point in NGLayoutOpportunityIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

Issue 2472583006: Add support of leader_point in NGLayoutOpportunityIterator. (Closed)

Patch Set: LayoutUnit(0) -> LayoutUnit() Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

index 456f33ddf3587841b7a41d7e3c503ce614072f61..04ca10c61bd458585ca10f79dfefa19b7ddbb69a 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

@@ -33,8 +33,8 @@ class CORE_EXPORT NGLayoutOpportunityIterator final

// text fragment for example.

NGLayoutOpportunityIterator(

NGConstraintSpace* space,

- const NGLogicalOffset origin_point = NGLogicalOffset(),

- const NGLogicalOffset leader_point = NGLogicalOffset());

+ const NGLogicalOffset& origin_point = NGLogicalOffset(),

+ const NGLogicalOffset& leader_point = NGLogicalOffset());

// Gets the next Layout Opportunity or nullptr if the search is exhausted.

// TODO(chrome-layout-team): Refactor with using C++ <iterator> library.

@@ -57,7 +57,6 @@ class CORE_EXPORT NGLayoutOpportunityIterator final

}

Member<NGConstraintSpace> constraint_space_;

- const NGLogicalOffset leader_point_;

NGLayoutOpportunities opportunities_;

NGLayoutOpportunities::const_iterator opportunity_iter_;