Fix namespace and primary display in ScreenBase.

Fix namespace and primary display in ScreenBase.

ScreenBase has unnecessary display:: namespaces all over. Remove them.
Also update GetPrimaryDisplay() to not crash if there is no primary
display.

BUG=657125
Committed: https://crrev.com/9825bba32903429ea01835f6cd6761b67dbd5a26
Cr-Commit-Position: refs/heads/master@{#429270}

[kylechar, 2016-11-01 21:11:29]

kylechar@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2016-11-01 22:03:37]

https://codereview.chromium.org/2472553002/diff/20001/ui/display/screen_base.cc
File ui/display/screen_base.cc (right):

https://codereview.chromium.org/2472553002/diff/20001/ui/display/screen_base....
ui/display/screen_base.cc:53: Display ScreenBase::GetPrimaryDisplay() const {
Can this function really be called when there are no primary displays?

[kylechar, 2016-11-01 22:07:13]

https://codereview.chromium.org/2472553002/diff/20001/ui/display/screen_base.cc
File ui/display/screen_base.cc (right):

https://codereview.chromium.org/2472553002/diff/20001/ui/display/screen_base....
ui/display/screen_base.cc:53: Display ScreenBase::GetPrimaryDisplay() const {
On 2016/11/01 22:03:37, sky wrote:
> Can this function really be called when there are no primary displays?

Yep :( Other instances of Screen implement (eg. ScreenAsh) something similar
where they will return an invalid display::Display if there is no primary
display. It would be nice to use ScreenBase with display::DisplayManager instead
of writing another Screen implementation from scratch.

[kylechar, 2016-11-01 22:18:30]

https://codereview.chromium.org/2472553002/diff/20001/ui/display/screen_base.cc
File ui/display/screen_base.cc (right):

https://codereview.chromium.org/2472553002/diff/20001/ui/display/screen_base....
ui/display/screen_base.cc:53: Display ScreenBase::GetPrimaryDisplay() const {
On 2016/11/01 22:07:13, kylechar wrote:
> On 2016/11/01 22:03:37, sky wrote:
> > Can this function really be called when there are no primary displays?
> 
> Yep :( Other instances of Screen implement (eg. ScreenAsh) something similar
> where they will return an invalid display::Display if there is no primary
> display. It would be nice to use ScreenBase with display::DisplayManager
instead
> of writing another Screen implementation from scratch.

On second though, I could add a NOTREACHED() to catch it happening but still not
crash release? I've triggered it a couple of times trying to get our async
display code working.

[sky, 2016-11-02 02:54:48]

If it can be called, LGTM

[kylechar, 2016-11-02 13:07:25]

The CQ bit was checked by kylechar@chromium.org

[commit-bot: I haz the power, 2016-11-02 13:07:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 14:10:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-02 14:14:11]

Description was changed from

==========
Fix namespace and primary display in ScreenBase.

ScreenBase has unnecessary display:: namespaces all over. Remove them.
Also update GetPrimaryDisplay() to not crash if there is no primary
display.

BUG=657125
==========

to

==========
Fix namespace and primary display in ScreenBase.

ScreenBase has unnecessary display:: namespaces all over. Remove them.
Also update GetPrimaryDisplay() to not crash if there is no primary
display.

BUG=657125

Committed: https://crrev.com/9825bba32903429ea01835f6cd6761b67dbd5a26
Cr-Commit-Position: refs/heads/master@{#429270}
==========

[commit-bot: I haz the power, 2016-11-02 14:14:12]

Patchset 2 (id:??) landed as
https://crrev.com/9825bba32903429ea01835f6cd6761b67dbd5a26
Cr-Commit-Position: refs/heads/master@{#429270}