Fix navigation requests starting too early and not getting associated with the <webview>.

Fix navigation requests starting too early and not getting associated with the <webview>.

The problem is for PlzNavigate, the ExtensionNavigationUIData is created when the NavigationHandle is created. We have to ensure it's not created before the relevant guestview structures are set up, which happens later for renderer created windows. So we have to wait until the RFH is ready (i.e. when it unblocks request through ResourceDispatcherHost) to create the NavigationHandle.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc
Cr-Commit-Position: refs/heads/master@{#430099}

[jam, 2016-11-04 00:33:44]

Description was changed from

==========
Fix navigation requests not being blocked for renderer initiated windows.

Without PlzNavigate, it worked in ResourceDispatcherHost as that was the entry
point. However with PlzNavigate, the new RenderFrameHost was making the request
and it was using uninitialized <webview> state since Init() wasn't called yet.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
==========

to

==========
Fix navigation requests not being blocked for renderer initiated windows.

Without PlzNavigate, it worked in ResourceDispatcherHost as that was the entry
point. However with PlzNavigate, the new RenderFrameHost was making the request
and it was using uninitialized <webview> state since Init() wasn't called yet.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2016-11-04 00:34:17]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 00:35:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-11-04 01:44:58]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 01:45:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 03:41:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 03:41:25]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[jam, 2016-11-04 05:48:14]

Description was changed from

==========
Fix navigation requests not being blocked for renderer initiated windows.

Without PlzNavigate, it worked in ResourceDispatcherHost as that was the entry
point. However with PlzNavigate, the new RenderFrameHost was making the request
and it was using uninitialized <webview> state since Init() wasn't called yet.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix navigation requests not being blocked for renderer initiated windows.

Without PlzNavigate, it worked in ResourceDispatcherHost as that was the entry
point. However with PlzNavigate, the new RenderFrameHost was making the request
and it was using uninitialized <webview> state since Init() wasn't called yet.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2016-11-04 05:50:03]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 05:50:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 06:34:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 06:34:19]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jam, 2016-11-04 06:46:28]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 06:46:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-11-04 06:53:33]

Patchset #3 (id:40001) has been deleted

[jam, 2016-11-04 06:53:34]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[jam, 2016-11-04 06:53:40]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-11-04 06:53:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 08:51:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 08:51:27]

Dry run: This issue passed the CQ dry run.

[jam, 2016-11-04 15:03:14]

jam@chromium.org changed reviewers:
+ fsamuel@chromium.org, nasko@chromium.org

[jam, 2016-11-04 15:03:15]

Fady: components/guest_view/browser/guest_view_message_filter.cc
Nasko: the rest

[Fady Samuel, 2016-11-04 17:31:51]

lgtm

[jam, 2016-11-04 18:10:49]

Description was changed from

==========
Fix navigation requests not being blocked for renderer initiated windows.

Without PlzNavigate, it worked in ResourceDispatcherHost as that was the entry
point. However with PlzNavigate, the new RenderFrameHost was making the request
and it was using uninitialized <webview> state since Init() wasn't called yet.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix navigation requests not being blocked for renderer initiated windows.

Without PlzNavigate, it worked in ResourceDispatcherHost as that was the entry
point. However with PlzNavigate, RenderFrameHost makes the navigation request
and it was using uninitialized <webview> state since Init() wasn't called yet.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2016-11-04 21:09:08]

Description was changed from

==========
Fix navigation requests not being blocked for renderer initiated windows.

Without PlzNavigate, it worked in ResourceDispatcherHost as that was the entry
point. However with PlzNavigate, RenderFrameHost makes the navigation request
and it was using uninitialized <webview> state since Init() wasn't called yet.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix navigation requests starting too early and not getting associated with the
<webview>.

The problem is for PlzNavigate, the ExtensionNavigationUIData is created when
the NavigationHandle is created. We have to ensure it's not created before the
relevant guestview structures are set up, which happens later for renderer
created windows. So we have to wait until the RFH is ready (i.e. when it
unblocks request through ResourceDispatcherHost) to create the NavigationHandle.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2016-11-04 21:36:13]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 21:37:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nasko, 2016-11-04 21:47:29]

LGTM with a couple of nits.

https://codereview.chromium.org/2472253002/diff/100001/content/browser/frame_...
File content/browser/frame_host/render_frame_host_impl.h (right):

https://codereview.chromium.org/2472253002/diff/100001/content/browser/frame_...
content/browser/frame_host/render_frame_host_impl.h:1045: // initiated request.
Init() will be called, and until then requests should
nit: "navigation requests"

https://codereview.chromium.org/2472253002/diff/100001/content/browser/frame_...
content/browser/frame_host/render_frame_host_impl.h:1050: PendingNavigate;
nit: PendingNavigation

[jam, 2016-11-04 22:14:01]

https://codereview.chromium.org/2472253002/diff/100001/content/browser/frame_...
File content/browser/frame_host/render_frame_host_impl.h (right):

https://codereview.chromium.org/2472253002/diff/100001/content/browser/frame_...
content/browser/frame_host/render_frame_host_impl.h:1045: // initiated request.
Init() will be called, and until then requests should
On 2016/11/04 21:47:29, nasko wrote:
> nit: "navigation requests"

Done.

[jam, 2016-11-04 22:14:25]

https://codereview.chromium.org/2472253002/diff/100001/content/browser/frame_...
File content/browser/frame_host/render_frame_host_impl.h (right):

https://codereview.chromium.org/2472253002/diff/100001/content/browser/frame_...
content/browser/frame_host/render_frame_host_impl.h:1050: PendingNavigate;
On 2016/11/04 21:47:29, nasko wrote:
> nit: PendingNavigation

Done.

[jam, 2016-11-04 22:14:35]

The CQ bit was checked by jam@chromium.org

[jam, 2016-11-04 22:14:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
fsamuel@chromium.org, nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2472253002/#ps70016
(title: "nits")

[commit-bot: I haz the power, 2016-11-04 22:15:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 00:46:45]

Description was changed from

==========
Fix navigation requests starting too early and not getting associated with the
<webview>.

The problem is for PlzNavigate, the ExtensionNavigationUIData is created when
the NavigationHandle is created. We have to ensure it's not created before the
relevant guestview structures are set up, which happens later for renderer
created windows. So we have to wait until the RFH is ready (i.e. when it
unblocks request through ResourceDispatcherHost) to create the NavigationHandle.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix navigation requests starting too early and not getting associated with the
<webview>.

The problem is for PlzNavigate, the ExtensionNavigationUIData is created when
the NavigationHandle is created. We have to ensure it's not created before the
relevant guestview structures are set up, which happens later for renderer
created windows. So we have to wait until the RFH is ready (i.e. when it
unblocks request through ResourceDispatcherHost) to create the NavigationHandle.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-11-05 00:46:46]

Committed patchset #5 (id:70016)

[commit-bot: I haz the power, 2016-11-05 00:50:45]

Description was changed from

==========
Fix navigation requests starting too early and not getting associated with the
<webview>.

The problem is for PlzNavigate, the ExtensionNavigationUIData is created when
the NavigationHandle is created. We have to ensure it's not created before the
relevant guestview structures are set up, which happens later for renderer
created windows. So we have to wait until the RFH is ready (i.e. when it
unblocks request through ResourceDispatcherHost) to create the NavigationHandle.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix navigation requests starting too early and not getting associated with the
<webview>.

The problem is for PlzNavigate, the ExtensionNavigationUIData is created when
the NavigationHandle is created. We have to ensure it's not created before the
relevant guestview structures are set up, which happens later for renderer
created windows. So we have to wait until the RFH is ready (i.e. when it
unblocks request through ResourceDispatcherHost) to create the NavigationHandle.

This fixes
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_DeclarativeWebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequest_1
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_0
WebViewInteractiveTests_WebViewNewWindowInteractiveTest.NewWindow_WebRequestRemoveElement_1
with PlzNavigate.

BUG=661811
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc
Cr-Commit-Position: refs/heads/master@{#430099}
==========

[commit-bot: I haz the power, 2016-11-05 00:50:46]

Patchset 5 (id:??) landed as
https://crrev.com/baaab3a22a5bf6d98be978a962361787d86aabdc
Cr-Commit-Position: refs/heads/master@{#430099}