Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Side by Side Diff: content/browser/frame_host/render_frame_host_manager.h

Issue 2472253002: Fix navigation requests starting too early and not getting associated with the <webview>. (Closed)
Patch Set: nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <list> 10 #include <list>
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 FrameTreeNode* frame_tree_node, 190 FrameTreeNode* frame_tree_node,
191 RenderFrameHostDelegate* render_frame_delegate, 191 RenderFrameHostDelegate* render_frame_delegate,
192 RenderWidgetHostDelegate* render_widget_delegate, 192 RenderWidgetHostDelegate* render_widget_delegate,
193 Delegate* delegate); 193 Delegate* delegate);
194 ~RenderFrameHostManager(); 194 ~RenderFrameHostManager();
195 195
196 // For arguments, see WebContentsImpl constructor. 196 // For arguments, see WebContentsImpl constructor.
197 void Init(SiteInstance* site_instance, 197 void Init(SiteInstance* site_instance,
198 int32_t view_routing_id, 198 int32_t view_routing_id,
199 int32_t frame_routing_id, 199 int32_t frame_routing_id,
200 int32_t widget_routing_id); 200 int32_t widget_routing_id,
201 bool renderer_initiated_creation);
201 202
202 // Returns the currently active RenderFrameHost. 203 // Returns the currently active RenderFrameHost.
203 // 204 //
204 // This will be non-NULL between Init() and Shutdown(). You may want to NULL 205 // This will be non-NULL between Init() and Shutdown(). You may want to NULL
205 // check it in many cases, however. Windows can send us messages during the 206 // check it in many cases, however. Windows can send us messages during the
206 // destruction process after it has been shut down. 207 // destruction process after it has been shut down.
207 RenderFrameHostImpl* current_frame_host() const { 208 RenderFrameHostImpl* current_frame_host() const {
208 return render_frame_host_.get(); 209 return render_frame_host_.get();
209 } 210 }
210 211
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
664 // |skip_this_node|. 665 // |skip_this_node|.
665 void CreateOpenerProxiesForFrameTree(SiteInstance* instance, 666 void CreateOpenerProxiesForFrameTree(SiteInstance* instance,
666 FrameTreeNode* skip_this_node); 667 FrameTreeNode* skip_this_node);
667 668
668 // Creates a RenderFrameHost and corresponding RenderViewHost if necessary. 669 // Creates a RenderFrameHost and corresponding RenderViewHost if necessary.
669 std::unique_ptr<RenderFrameHostImpl> CreateRenderFrameHost( 670 std::unique_ptr<RenderFrameHostImpl> CreateRenderFrameHost(
670 SiteInstance* instance, 671 SiteInstance* instance,
671 int32_t view_routing_id, 672 int32_t view_routing_id,
672 int32_t frame_routing_id, 673 int32_t frame_routing_id,
673 int32_t widget_routing_id, 674 int32_t widget_routing_id,
674 bool hidden); 675 bool hidden,
676 bool renderer_initiated_creation);
675 677
676 // PlzNavigate 678 // PlzNavigate
677 // Create and initialize a speculative RenderFrameHost for an ongoing 679 // Create and initialize a speculative RenderFrameHost for an ongoing
678 // navigation. It might be destroyed and re-created later if the navigation 680 // navigation. It might be destroyed and re-created later if the navigation
679 // is redirected to a different SiteInstance. 681 // is redirected to a different SiteInstance.
680 bool CreateSpeculativeRenderFrameHost(SiteInstance* old_instance, 682 bool CreateSpeculativeRenderFrameHost(SiteInstance* old_instance,
681 SiteInstance* new_instance); 683 SiteInstance* new_instance);
682 684
683 // Initialization for RenderFrameHost uses the same sequence as InitRenderView 685 // Initialization for RenderFrameHost uses the same sequence as InitRenderView
684 // above. 686 // above.
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
804 std::unique_ptr<RenderFrameHostImpl> speculative_render_frame_host_; 806 std::unique_ptr<RenderFrameHostImpl> speculative_render_frame_host_;
805 807
806 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_; 808 base::WeakPtrFactory<RenderFrameHostManager> weak_factory_;
807 809
808 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager); 810 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager);
809 }; 811 };
810 812
811 } // namespace content 813 } // namespace content
812 814
813 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_ 815 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/frame_host/render_frame_host_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698