Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: content/browser/frame_host/render_frame_host_factory.h

Issue 2472253002: Fix navigation requests starting too early and not getting associated with the <webview>. (Closed)
Patch Set: nits Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 20 matching lines...) Expand all
31 // or a regular RenderFrameHostImpl if no factory is registered. 31 // or a regular RenderFrameHostImpl if no factory is registered.
32 static std::unique_ptr<RenderFrameHostImpl> Create( 32 static std::unique_ptr<RenderFrameHostImpl> Create(
33 SiteInstance* site_instance, 33 SiteInstance* site_instance,
34 RenderViewHostImpl* render_view_host, 34 RenderViewHostImpl* render_view_host,
35 RenderFrameHostDelegate* delegate, 35 RenderFrameHostDelegate* delegate,
36 RenderWidgetHostDelegate* rwh_delegate, 36 RenderWidgetHostDelegate* rwh_delegate,
37 FrameTree* frame_tree, 37 FrameTree* frame_tree,
38 FrameTreeNode* frame_tree_node, 38 FrameTreeNode* frame_tree_node,
39 int32_t routing_id, 39 int32_t routing_id,
40 int32_t widget_routing_id, 40 int32_t widget_routing_id,
41 bool hidden); 41 bool hidden,
42 bool renderer_initiated_creation);
42 43
43 // Returns true if there is currently a globally-registered factory. 44 // Returns true if there is currently a globally-registered factory.
44 static bool has_factory() { return !!factory_; } 45 static bool has_factory() { return !!factory_; }
45 46
46 protected: 47 protected:
47 RenderFrameHostFactory() {} 48 RenderFrameHostFactory() {}
48 virtual ~RenderFrameHostFactory() {} 49 virtual ~RenderFrameHostFactory() {}
49 50
50 // You can derive from this class and specify an implementation for this 51 // You can derive from this class and specify an implementation for this
51 // function to create an alternate kind of RenderFrameHostImpl for testing. 52 // function to create an alternate kind of RenderFrameHostImpl for testing.
52 virtual std::unique_ptr<RenderFrameHostImpl> CreateRenderFrameHost( 53 virtual std::unique_ptr<RenderFrameHostImpl> CreateRenderFrameHost(
53 SiteInstance* site_instance, 54 SiteInstance* site_instance,
54 RenderViewHostImpl* render_view_host, 55 RenderViewHostImpl* render_view_host,
55 RenderFrameHostDelegate* delegate, 56 RenderFrameHostDelegate* delegate,
56 RenderWidgetHostDelegate* rwh_delegate, 57 RenderWidgetHostDelegate* rwh_delegate,
57 FrameTree* frame_tree, 58 FrameTree* frame_tree,
58 FrameTreeNode* frame_tree_node, 59 FrameTreeNode* frame_tree_node,
59 int32_t routing_id, 60 int32_t routing_id,
60 int32_t widget_routing_id, 61 int32_t widget_routing_id,
61 bool hidden) = 0; 62 bool hidden,
63 bool renderer_initiated_creation) = 0;
62 64
63 // Registers a factory to be called when new RenderFrameHostImpls are created. 65 // Registers a factory to be called when new RenderFrameHostImpls are created.
64 // We have only one global factory, so there must be no factory registered 66 // We have only one global factory, so there must be no factory registered
65 // before the call. This class does NOT take ownership of the pointer. 67 // before the call. This class does NOT take ownership of the pointer.
66 static void RegisterFactory(RenderFrameHostFactory* factory); 68 static void RegisterFactory(RenderFrameHostFactory* factory);
67 69
68 // Unregister the previously registered factory. With no factory registered, 70 // Unregister the previously registered factory. With no factory registered,
69 // regular RenderFrameHostImpls will be created. 71 // regular RenderFrameHostImpls will be created.
70 static void UnregisterFactory(); 72 static void UnregisterFactory();
71 73
72 private: 74 private:
73 // The current globally registered factory. This is NULL when we should create 75 // The current globally registered factory. This is NULL when we should create
74 // regular RenderFrameHostImpls. 76 // regular RenderFrameHostImpls.
75 static RenderFrameHostFactory* factory_; 77 static RenderFrameHostFactory* factory_;
76 78
77 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostFactory); 79 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostFactory);
78 }; 80 };
79 81
80 } // namespace content 82 } // namespace content
81 83
82 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_ 84 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_FACTORY_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/interstitial_page_impl.cc ('k') | content/browser/frame_host/render_frame_host_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698