Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: content/browser/indexed_db/indexed_db_backing_store_unittest.cc

Issue 2472213003: [IndexedDB] Refactoring to remove ref ptrs and host transaction ids. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_backing_store_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
index f9ce90c6ba0f6e4401c9396f4a3b35640b9072bc..4791ab16a637b836cd23033eceb783ca244287fe 100644
--- a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc
@@ -375,9 +375,18 @@ class IndexedDBBackingStoreTest : public testing::Test {
class TestCallback : public IndexedDBBackingStore::BlobWriteCallback {
public:
TestCallback() : called(false), succeeded(false) {}
- void Run(bool succeeded_in) override {
+ leveldb::Status Run(IndexedDBBackingStore::BlobWriteResult result) override {
called = true;
- succeeded = succeeded_in;
+ switch(result) {
cmumford 2016/12/01 19:14:51 Add space before (
dmurph 2016/12/01 21:12:23 Done.
+ case IndexedDBBackingStore::BlobWriteResult::FAIILURE_ASYNC:
+ succeeded = false;
+ break;
+ case IndexedDBBackingStore::BlobWriteResult::SUCCESS_ASYNC:
cmumford 2016/12/01 19:14:51 Nit: Could replace the switch with: succeeded =
dmurph 2016/12/01 21:12:23 I'd rather have the switch statement so that it fa
+ case IndexedDBBackingStore::BlobWriteResult::SUCCESS_SYNC:
+ succeeded = true;
+ break;
+ }
+ return leveldb::Status::OK();
}
bool called;
bool succeeded;

Powered by Google App Engine
This is Rietveld 408576698