Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: content/browser/indexed_db/indexed_db_callbacks.h

Issue 2472213003: [IndexedDB] Refactoring to remove ref ptrs and host transaction ids. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_callbacks.h
diff --git a/content/browser/indexed_db/indexed_db_callbacks.h b/content/browser/indexed_db/indexed_db_callbacks.h
index bf26a1d436bd4eb4e24d13230298046339bd3de6..6b698b67831a2a6b2d906ae161d36f298f79322a 100644
--- a/content/browser/indexed_db/indexed_db_callbacks.h
+++ b/content/browser/indexed_db/indexed_db_callbacks.h
@@ -31,6 +31,7 @@ class IndexedDBDatabase;
struct IndexedDBDataLossInfo;
struct IndexedDBDatabaseMetadata;
struct IndexedDBReturnValue;
+class IndexedDBTransaction;
struct IndexedDBValue;
class CONTENT_EXPORT IndexedDBCallbacks
@@ -53,13 +54,14 @@ class CONTENT_EXPORT IndexedDBCallbacks
virtual void OnUpgradeNeeded(
int64_t old_version,
std::unique_ptr<IndexedDBConnection> connection,
+ IndexedDBTransaction* transaction,
const content::IndexedDBDatabaseMetadata& metadata,
const IndexedDBDataLossInfo& data_loss_info);
virtual void OnSuccess(std::unique_ptr<IndexedDBConnection> connection,
const content::IndexedDBDatabaseMetadata& metadata);
// IndexedDBDatabase::OpenCursor
- virtual void OnSuccess(scoped_refptr<IndexedDBCursor> cursor,
+ virtual void OnSuccess(std::unique_ptr<IndexedDBCursor> cursor,
const IndexedDBKey& key,
const IndexedDBKey& primary_key,
IndexedDBValue* value);
@@ -99,10 +101,6 @@ class CONTENT_EXPORT IndexedDBCallbacks
void SetConnectionOpenStartTime(const base::TimeTicks& start_time);
- void set_host_transaction_id(int64_t host_transaction_id) {
- host_transaction_id_ = host_transaction_id;
- }
-
protected:
virtual ~IndexedDBCallbacks();
@@ -118,7 +116,6 @@ class CONTENT_EXPORT IndexedDBCallbacks
scoped_refptr<IndexedDBDispatcherHost> dispatcher_host_;
// IndexedDBDatabase callbacks ------------------------
- int64_t host_transaction_id_;
url::Origin origin_;
bool database_sent_ = false;

Powered by Google App Engine
This is Rietveld 408576698