[IndexedDB] Refactoring to remove ref ptrs and host transaction ids.

content/browser/indexed_db/indexed_db_backing_store_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_backing_store.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <utility>
 
@@ skipping 357 matching lines @@
   IndexedDBValue m_value3;
   std::vector<IndexedDBBlobInfo> m_blob_info;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(IndexedDBBackingStoreTest);
 };
 
 class TestCallback : public IndexedDBBackingStore::BlobWriteCallback {
  public:
   TestCallback() : called(false), succeeded(false) {}
-  void Run(bool succeeded_in) override {
+  leveldb::Status Run(IndexedDBBackingStore::BlobWriteResult result) override {
     called = true;
-    succeeded = succeeded_in;
+    switch(result) {

[cmumford, 2016/12/01 19:14:51]

Add space before (

[dmurph, 2016/12/01 21:12:23]

Done.

+      case IndexedDBBackingStore::BlobWriteResult::FAIILURE_ASYNC:
+        succeeded = false;
+        break;
+      case IndexedDBBackingStore::BlobWriteResult::SUCCESS_ASYNC:

[cmumford, 2016/12/01 19:14:51]

Nit: Could replace the switch with:

  succeeded = (result !=
IndexedDBBackingStore::BlobWriteResult::FAIILURE_ASYNC);

Your call if you prefer as-is.

[dmurph, 2016/12/01 21:12:23]

I'd rather have the switch statement so that it fails to compile if anyone
changes the enum.

+      case IndexedDBBackingStore::BlobWriteResult::SUCCESS_SYNC:
+        succeeded = true;
+        break;
+    }
+    return leveldb::Status::OK();
   }
   bool called;
   bool succeeded;
 
  protected:
   ~TestCallback() override {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TestCallback);
 };
@@ skipping 758 matching lines @@
 
   // Dictionary, message key and more.
   ASSERT_TRUE(WriteFile(info_path, "{\"message\":\"foo\",\"bar\":5}"));
   EXPECT_TRUE(
       IndexedDBBackingStore::ReadCorruptionInfo(path_base, origin, &message));
   EXPECT_FALSE(PathExists(info_path));
   EXPECT_EQ("foo", message);
 }
 
 }  // namespace content