Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc

Issue 2471853002: remove 'unsafe' from ES3 apis in gpu process (Closed)
Patch Set: forgot to save file Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 2068 matching lines...) Expand 10 before | Expand all | Expand 10 after
2079 EXPECT_NE(error::kNoError, ExecuteCmd(cmd)); 2079 EXPECT_NE(error::kNoError, ExecuteCmd(cmd));
2080 cmd.Init(client_program_id_, 2080 cmd.Init(client_program_id_,
2081 kBucketId, 2081 kBucketId,
2082 kSharedMemoryId, 2082 kSharedMemoryId,
2083 kInvalidSharedMemoryOffset); 2083 kInvalidSharedMemoryOffset);
2084 EXPECT_NE(error::kNoError, ExecuteCmd(cmd)); 2084 EXPECT_NE(error::kNoError, ExecuteCmd(cmd));
2085 } 2085 }
2086 2086
2087 TEST_P(GLES3DecoderWithShaderTest, Basic) { 2087 TEST_P(GLES3DecoderWithShaderTest, Basic) {
2088 // Make sure the setup is correct for ES3. 2088 // Make sure the setup is correct for ES3.
2089 EXPECT_TRUE(decoder_->unsafe_es3_apis_enabled()); 2089 EXPECT_TRUE(feature_info()->IsWebGL2OrES3Context());
2090 EXPECT_TRUE(feature_info()->validators()->texture_bind_target.IsValid( 2090 EXPECT_TRUE(feature_info()->validators()->texture_bind_target.IsValid(
2091 GL_TEXTURE_3D)); 2091 GL_TEXTURE_3D));
2092 } 2092 }
2093 2093
2094 TEST_P(GLES3DecoderWithShaderTest, UniformBlockBindingValidArgs) { 2094 TEST_P(GLES3DecoderWithShaderTest, UniformBlockBindingValidArgs) {
2095 EXPECT_CALL(*gl_, UniformBlockBinding(kServiceProgramId, 1, 3)); 2095 EXPECT_CALL(*gl_, UniformBlockBinding(kServiceProgramId, 1, 3));
2096 SpecializedSetup<UniformBlockBinding, 0>(true); 2096 SpecializedSetup<UniformBlockBinding, 0>(true);
2097 UniformBlockBinding cmd; 2097 UniformBlockBinding cmd;
2098 cmd.Init(client_program_id_, 1, 3); 2098 cmd.Init(client_program_id_, 1, 3);
2099 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd)); 2099 EXPECT_EQ(error::kNoError, ExecuteCmd(cmd));
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
2228 } 2228 }
2229 2229
2230 // TODO(gman): DeleteProgram 2230 // TODO(gman): DeleteProgram
2231 2231
2232 // TODO(gman): UseProgram 2232 // TODO(gman): UseProgram
2233 2233
2234 // TODO(gman): DeleteShader 2234 // TODO(gman): DeleteShader
2235 2235
2236 } // namespace gles2 2236 } // namespace gles2
2237 } // namespace gpu 2237 } // namespace gpu
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698