Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2471913003:
change enable_es3 to context_type in SetupFeatureInfo (Closed)
|
Created:
4 years, 1 month ago by Kai Ninomiya Modified:
4 years, 1 month ago CC:
chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionchange enable_es3 to context_type in SetupFeatureInfo
BUG=654787
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/ea52386cb9c58ce4a7e05db8590623fc5bf15227
Cr-Commit-Position: refs/heads/master@{#429512}
Patch Set 1 #Patch Set 2 : update #
Depends on Patchset: Messages
Total messages: 21 (14 generated)
Description was changed from ========== change enable_es3 to context_type in SetupFeatureInfo and remove 'unsafe' from gpu preferences BUG=654787 ========== to ========== change enable_es3 to context_type in SetupFeatureInfo and remove 'unsafe' from gpu preferences BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
kainino@chromium.org changed reviewers: + zmo@chromium.org
A little more cleanup on top of the previous patch. zmo: PTAL
On 2016/11/03 00:23:14, Kai Ninomiya wrote: > A little more cleanup on top of the previous patch. > > zmo: PTAL oops, hold off until I fix the build
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
Description was changed from ========== change enable_es3 to context_type in SetupFeatureInfo and remove 'unsafe' from gpu preferences BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== change enable_es3 to context_type in SetupFeatureInfo BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/03 00:23:53, Kai Ninomiya wrote: > On 2016/11/03 00:23:14, Kai Ninomiya wrote: > > A little more cleanup on top of the previous patch. > > > > zmo: PTAL > > oops, hold off until I fix the build okay, fixed
On 2016/11/03 00:33:23, Kai Ninomiya wrote: > On 2016/11/03 00:23:53, Kai Ninomiya wrote: > > On 2016/11/03 00:23:14, Kai Ninomiya wrote: > > > A little more cleanup on top of the previous patch. > > > > > > zmo: PTAL > > > > oops, hold off until I fix the build > > okay, fixed neat! lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kainino@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing to commit, working tree clean
Message was sent while issue was closed.
Description was changed from ========== change enable_es3 to context_type in SetupFeatureInfo BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== change enable_es3 to context_type in SetupFeatureInfo BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/ea52386cb9c58ce4a7e05db8590623fc5bf15227 Cr-Commit-Position: refs/heads/master@{#429512} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ea52386cb9c58ce4a7e05db8590623fc5bf15227 Cr-Commit-Position: refs/heads/master@{#429512} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
