|
Revert of Make more media APIs aware of |delay| and |delay_timestamp| (patchset #7 id:200001 of https://codereview.chromium.org/2437863004/ )
Reason for revert:
This breaks built in speech synthesis on Chrome OS. To reproduce, simply use web speech to speak something e.g. speechSynthesis.speak(new SpeechSynthesisUtterance('test'));
The patch also wasn't 'git cl format'ed.
Original issue's description:
> Make more media APIs aware of |delay| and |delay_timestamp|
>
> This patch is a part of 'AudioContext.getOutputTimestamp' method implementation [1] and it continues the changes introduced at [2].
>
> The AudioRendererSink::RenderCallback::Render method has same semantics as AudioSourceCallback::OnMoreData.
> That caused other changes in the following interfaces:
> - AudioSyncReader::UpdatePendingBytes(uint32_t bytes, uint32_t frames_skipped) -> AudioSyncReader::PrepareNextData(base::TimeDelta delay, base::TimeTicks delay_timestamp, uint32_t frames_skipped)
> - AudioDeviceThread::Callback::Process(uint32_t pending_data) -> AudioDeviceThread::Callback::Process(int64_t pending_data, base::TimeTicks data_timestamp)
> - AudioDeviceThread is receiving a "packet" of two int64_t values
>
> BUG= 619533
>
> [1] https://codereview.chromium.org/2060833002/
> [2] https://codereview.chromium.org/2101303004/
>
> Committed: https://crrev.com/df872a842609926a62e0211868c886d0ec96cff7
> Committed: https://crrev.com/06d9d80a203b9c329fc6d53fde44bae66645a389
> Cr-Original-Commit-Position: refs/heads/master@{#427996}
> Cr-Commit-Position: refs/heads/master@{#428953}
TBR=jochen@chromium.org,chcunningham@chromium.org,jameswest@google.com,jameswest@chromium.org,miu@chromium.org,perkj@chromium.org,tommi@chromium.org,mikhail.pozdnyakov@intel.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 619533
TBR=tommi@chromium.org
NOTRY=true
NOPRESUBMIT=true
Committed: https://crrev.com/2665e952502835c6c37d51153bfa180343635a41
Cr-Commit-Position: refs/heads/master@{#429412}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+201 lines, -283 lines) |
Patch |
 |
M |
content/browser/renderer_host/media/audio_input_sync_writer.cc
|
View
|
|
2 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc
|
View
|
|
3 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/media/audio_sync_reader.h
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/media/audio_sync_reader.cc
|
View
|
|
2 chunks |
+4 lines, -9 lines |
0 comments
|
Download
|
 |
M |
content/renderer/media/renderer_webaudiodevice_impl.h
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
content/renderer/media/renderer_webaudiodevice_impl.cc
|
View
|
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
content/renderer/media/track_audio_renderer.h
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
content/renderer/media/track_audio_renderer.cc
|
View
|
|
2 chunks |
+11 lines, -6 lines |
0 comments
|
Download
|
 |
M |
content/renderer/media/webrtc_audio_renderer.h
|
View
|
|
2 chunks |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
content/renderer/media/webrtc_audio_renderer.cc
|
View
|
|
5 chunks |
+23 lines, -13 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_device_thread.h
|
View
|
|
2 chunks |
+1 line, -8 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_device_thread.cc
|
View
|
|
2 chunks |
+6 lines, -9 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_input_device.cc
|
View
|
|
3 chunks |
+5 lines, -7 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_output_controller.h
|
View
|
|
1 chunk |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_output_controller.cc
|
View
|
|
4 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_output_controller_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -5 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_output_device.cc
|
View
|
|
4 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_output_device_unittest.cc
|
View
|
|
4 chunks |
+10 lines, -13 lines |
0 comments
|
Download
|
 |
M |
media/audio/audio_output_stream_sink.cc
|
View
|
|
2 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
media/audio/clockless_audio_sink.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
media/audio/null_audio_sink.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
media/base/audio_bus_perftest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
media/base/audio_converter_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
media/base/audio_hash_unittest.cc
|
View
|
|
1 chunk |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
media/base/audio_renderer_mixer.h
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/base/audio_renderer_mixer.cc
|
View
|
|
3 chunks |
+3 lines, -7 lines |
0 comments
|
Download
|
 |
M |
media/base/audio_renderer_mixer_input.cc
|
View
|
|
2 chunks |
+1 line, -6 lines |
0 comments
|
Download
|
 |
M |
media/base/audio_renderer_mixer_unittest.cc
|
View
|
|
3 chunks |
+4 lines, -8 lines |
0 comments
|
Download
|
 |
M |
media/base/audio_renderer_sink.h
|
View
|
|
1 chunk |
+7 lines, -8 lines |
0 comments
|
Download
|
 |
M |
media/base/fake_audio_render_callback.h
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/base/fake_audio_render_callback.cc
|
View
|
|
2 chunks |
+3 lines, -7 lines |
0 comments
|
Download
|
 |
M |
media/base/fake_audio_renderer_sink.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/base/fake_audio_renderer_sink.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
media/base/silent_sink_suspender.h
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/base/silent_sink_suspender.cc
|
View
|
|
4 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
 |
M |
media/base/silent_sink_suspender_unittest.cc
|
View
|
|
8 chunks |
+14 lines, -39 lines |
0 comments
|
Download
|
 |
M |
media/blink/webaudiosourceprovider_impl.cc
|
View
|
|
5 chunks |
+10 lines, -18 lines |
0 comments
|
Download
|
 |
M |
media/blink/webaudiosourceprovider_impl_unittest.cc
|
View
|
|
2 chunks |
+4 lines, -7 lines |
0 comments
|
Download
|
 |
M |
media/renderers/audio_renderer_impl.h
|
View
|
|
1 chunk |
+4 lines, -5 lines |
0 comments
|
Download
|
 |
M |
media/renderers/audio_renderer_impl.cc
|
View
|
|
1 chunk |
+5 lines, -9 lines |
0 comments
|
Download
|
 |
M |
media/renderers/audio_renderer_impl_unittest.cc
|
View
|
|
5 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
Total messages: 18 (10 generated)
|