Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2471663002: ABANDONED CL: CtrlClickShouldEndUpInNewProcess - test for https://crbug.com/23815 (Closed)

Created:
4 years, 1 month ago by Łukasz Anforowicz
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ABANDONED CL - this CL has been replaced by https://codereview.chromium.org/2686943002 ============================ New WebContents created via ctrl-click should be in a new process. BUG=23815, 658386

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : One more test - for target="_blank". #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -3 lines) Patch
M chrome/browser/chrome_navigation_browsertest.cc View 2 chunks +168 lines, -0 lines 0 comments Download
chrome/browser/ui/browser_navigator.cc View 1 chunk +1 line, -3 lines 0 comments Download
chrome/test/data/frame_tree/anchor_to_same_site_location.html View 1 chunk +25 lines, -0 lines 0 comments Download
content/shell/browser/shell.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (8 generated)
Łukasz Anforowicz
Description was changed from ========== CtrlClickShouldEndUpInNewProcess - test for https://crbug.com/23815 BUG=23815 ========== to ========== New ...
4 years, 1 month ago (2016-11-01 21:15:56 UTC) #1
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-01 21:49:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471663002/20001
4 years, 1 month ago (2016-11-01 21:50:36 UTC) #3
Łukasz Anforowicz
The CQ bit was checked by lukasza@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-01 22:20:40 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471663002/40001
4 years, 1 month ago (2016-11-01 22:21:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-01 23:17:17 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/306944)
4 years, 1 month ago (2016-11-01 23:17:18 UTC) #7
Łukasz Anforowicz
3 years, 8 months ago (2017-04-14 16:35:28 UTC) #8 
Description was changed from

==========
New WebContents created via ctrl-click should be in a new process.

BUG=23815, 658386
==========

to

==========
ABANDONED CL - this CL has been replaced by
https://codereview.chromium.org/2686943002 

============================

New WebContents created via ctrl-click should be in a new process.

BUG=23815, 658386
==========

Powered by Google App Engine
This is Rietveld 408576698