chrome/browser/ui/browser_navigator.cc - Issue 2471663002: ABANDONED CL: CtrlClickShouldEndUpInNewProcess - test for https://crbug.com/23815

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 2471663002: ABANDONED CL: CtrlClickShouldEndUpInNewProcess - test for https://crbug.com/23815 (Closed)

Patch Set: One more test - for target="_blank". Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_navigator.cc

diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc

index 66a92f9d8a2f27a321feb9950c6c1cdcd950d602..3cc29667a0a180bac9874b67422828f8127f585b 100644

--- a/chrome/browser/ui/browser_navigator.cc

+++ b/chrome/browser/ui/browser_navigator.cc

@@ -350,9 +350,7 @@ content::WebContents* CreateTargetContents(const chrome::NavigateParams& params,

const GURL& url) {

WebContents::CreateParams create_params(

params.browser->profile(),

- params.source_site_instance

- ? params.source_site_instance

- : tab_util::GetSiteInstanceForNewTab(params.browser->profile(), url));

+ tab_util::GetSiteInstanceForNewTab(params.browser->profile(), url));

create_params.main_frame_name = params.frame_name;

if (params.source_contents) {

create_params.initial_size =