content/shell/browser/shell.cc - Issue 2471663002: ABANDONED CL: CtrlClickShouldEndUpInNewProcess - test for https://crbug.com/23815

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell.cc

Issue 2471663002: ABANDONED CL: CtrlClickShouldEndUpInNewProcess - test for https://crbug.com/23815 (Closed)

Patch Set: One more test - for target="_blank". Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/browser/shell.cc

diff --git a/content/shell/browser/shell.cc b/content/shell/browser/shell.cc

index 9d74a1cd680b3eb69c892228f66de0e4c4294ac1..081c0f68c497951f08a03e566e58a2f13e2d0b29 100644

--- a/content/shell/browser/shell.cc

+++ b/content/shell/browser/shell.cc

@@ -328,6 +328,8 @@ WebContents* Shell::OpenURLFromTab(WebContents* source,

Shell* new_window =

Shell::CreateNewWindow(source->GetBrowserContext(),

GURL(), // Don't load anything just yet.

+ // TODO(lukasza): Pass nullptr below for

+ // consistency with //chrome layer.

params.source_site_instance,

gfx::Size()); // Use default size.

target = new_window->web_contents();

« no previous file with comments | « chrome/test/data/frame_tree/anchor_to_same_site_location.html ('k') | no next file » | no next file with comments »