Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 2471563003: Revert of [Tracing] Create TracingCategoryObserver in gin/. (Closed)

Created:
4 years, 1 month ago by lpy
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Tracing] Create TracingCategoryObserver in gin/. (patchset #2 id:20001 of https://codereview.chromium.org/2456073004/ ) Reason for revert: Revert this patch because clusterfuzz complains about bad casting. Original issue's description: > [Tracing] Create TracingCategoryObserver in gin/. > > Previously we implemented TracingCategoryObserver in V8 in order to do fast > category check when we enable V8 specific tracing feature in a unified way. > This patch calls the the creation of TracingCategoryObserver from chrome and > adds it to observer list. > > BUG=v8:5590 > > Committed: https://crrev.com/f3b25db89a2dfaad59a90573fe355bc60db0a899 > Cr-Commit-Position: refs/heads/master@{#428756} TBR=jochen@chromium.org,fmeawad@chromium.org,alph@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5590 Committed: https://crrev.com/241ab2fc21762ba47c4a3a088c10338f47a87359 Cr-Commit-Position: refs/heads/master@{#429160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M gin/v8_platform.cc View 3 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
lpy
Created Revert of [Tracing] Create TracingCategoryObserver in gin/.
4 years, 1 month ago (2016-11-01 22:32:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471563003/1
4 years, 1 month ago (2016-11-01 22:32:58 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-01 22:33:00 UTC) #5
fmeawad
lgtm
4 years, 1 month ago (2016-11-01 22:33:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471563003/1
4 years, 1 month ago (2016-11-01 22:34:41 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/184567)
4 years, 1 month ago (2016-11-01 23:02:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471563003/1
4 years, 1 month ago (2016-11-01 23:04:33 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 00:28:50 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 00:31:03 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/241ab2fc21762ba47c4a3a088c10338f47a87359
Cr-Commit-Position: refs/heads/master@{#429160}

Powered by Google App Engine
This is Rietveld 408576698