Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2456073004:
[Tracing] Create TracingCategoryObserver in gin/. (Closed)
Description[Tracing] Create TracingCategoryObserver in gin/.
Previously we implemented TracingCategoryObserver in V8 in order to do fast
category check when we enable V8 specific tracing feature in a unified way.
This patch calls the the creation of TracingCategoryObserver from chrome and
adds it to observer list.
BUG=v8:5590
Committed: https://crrev.com/f3b25db89a2dfaad59a90573fe355bc60db0a899
Cr-Commit-Position: refs/heads/master@{#428756}
Patch Set 1 #Patch Set 2 : rebase #
Total comments: 2
Messages
Total messages: 22 (15 generated)
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Create TracingCategoryObserver in gin/. Previously we implemented TracingCategoryObserver in V8 in order to do fast category check when we enable V8 specific tracing feature in a unified way. This patch calls the the creation of TracingCategoryObserver from chrome and adds it to observer list. ========== to ========== [Tracing] Create TracingCategoryObserver in gin/. Previously we implemented TracingCategoryObserver in V8 in order to do fast category check when we enable V8 specific tracing feature in a unified way. This patch calls the the creation of TracingCategoryObserver from chrome and adds it to observer list. ==========
lpy@chromium.org changed reviewers: + fmeawad@chromium.org, jochen@chromium.org
PTAL.
The CQ bit was unchecked by lpy@chromium.org
lgtm when the bots are happy please add a tracking bug to the CL description
Description was changed from ========== [Tracing] Create TracingCategoryObserver in gin/. Previously we implemented TracingCategoryObserver in V8 in order to do fast category check when we enable V8 specific tracing feature in a unified way. This patch calls the the creation of TracingCategoryObserver from chrome and adds it to observer list. ========== to ========== [Tracing] Create TracingCategoryObserver in gin/. Previously we implemented TracingCategoryObserver in V8 in order to do fast category check when we enable V8 specific tracing feature in a unified way. This patch calls the the creation of TracingCategoryObserver from chrome and adds it to observer list. BUG=v8:5590 ==========
The CQ bit was checked by lpy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lpy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org Link to the patchset: https://codereview.chromium.org/2456073004/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Tracing] Create TracingCategoryObserver in gin/. Previously we implemented TracingCategoryObserver in V8 in order to do fast category check when we enable V8 specific tracing feature in a unified way. This patch calls the the creation of TracingCategoryObserver from chrome and adds it to observer list. BUG=v8:5590 ========== to ========== [Tracing] Create TracingCategoryObserver in gin/. Previously we implemented TracingCategoryObserver in V8 in order to do fast category check when we enable V8 specific tracing feature in a unified way. This patch calls the the creation of TracingCategoryObserver from chrome and adds it to observer list. BUG=v8:5590 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Tracing] Create TracingCategoryObserver in gin/. Previously we implemented TracingCategoryObserver in V8 in order to do fast category check when we enable V8 specific tracing feature in a unified way. This patch calls the the creation of TracingCategoryObserver from chrome and adds it to observer list. BUG=v8:5590 ========== to ========== [Tracing] Create TracingCategoryObserver in gin/. Previously we implemented TracingCategoryObserver in V8 in order to do fast category check when we enable V8 specific tracing feature in a unified way. This patch calls the the creation of TracingCategoryObserver from chrome and adds it to observer list. BUG=v8:5590 Committed: https://crrev.com/f3b25db89a2dfaad59a90573fe355bc60db0a899 Cr-Commit-Position: refs/heads/master@{#428756} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f3b25db89a2dfaad59a90573fe355bc60db0a899 Cr-Commit-Position: refs/heads/master@{#428756}
Message was sent while issue was closed.
alph@chromium.org changed reviewers: + alph@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2456073004/diff/20001/gin/v8_platform.cc File gin/v8_platform.cc (right): https://codereview.chromium.org/2456073004/diff/20001/gin/v8_platform.cc#newc... gin/v8_platform.cc:159: tracing_category_observer_ = v8::tracing::TracingCategoryObserver::Create(); Why it belongs here? It should be an internal class in V8. https://codereview.chromium.org/2456073004/diff/20001/gin/v8_platform.cc#newc... gin/v8_platform.cc:160: observers_.insert(reinterpret_cast<v8::Platform::TraceStateObserver*>( Reinterpret cast between interfaces won't work.
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2471563003/ by lpy@chromium.org. The reason for reverting is: Revert this patch because clusterfuzz complains about bad casting.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
