Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: gin/v8_platform.cc

Issue 2471563003: Revert of [Tracing] Create TracingCategoryObserver in gin/. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/v8_platform.cc
diff --git a/gin/v8_platform.cc b/gin/v8_platform.cc
index d334332592daee6e59cc76c4c55ea4993031e283..945eee0cc3d9798730130ebbe44d3d5acb92d4f7 100644
--- a/gin/v8_platform.cc
+++ b/gin/v8_platform.cc
@@ -10,7 +10,6 @@
#include "base/threading/worker_pool.h"
#include "base/trace_event/trace_event.h"
#include "gin/per_isolate_data.h"
-#include "v8/include/v8-tracing.h"
namespace gin {
@@ -155,11 +154,7 @@
class EnabledStateObserverImpl final
: public base::trace_event::TraceLog::EnabledStateObserver {
public:
- EnabledStateObserverImpl() {
- tracing_category_observer_ = v8::tracing::TracingCategoryObserver::Create();
- observers_.insert(reinterpret_cast<v8::Platform::TraceStateObserver*>(
- tracing_category_observer_.get()));
- }
+ EnabledStateObserverImpl() = default;
void OnTraceLogEnabled() final {
base::AutoLock lock(mutex_);
@@ -197,8 +192,6 @@
private:
base::Lock mutex_;
std::unordered_set<v8::Platform::TraceStateObserver*> observers_;
- std::unique_ptr<v8::tracing::TracingCategoryObserver>
- tracing_category_observer_;
DISALLOW_COPY_AND_ASSIGN(EnabledStateObserverImpl);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698