Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl

Issue 2471393004: bindings: Use forward declarations for wrapper types in dictionary_impl (Closed)
Patch Set: Added copy operator Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl
index b1c55e02b0bc2472e26907bcc151312ee92fae18..69df026df4f05513047e79a88580381ed8acf4d1 100644
--- a/third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl
@@ -18,6 +18,10 @@ namespace blink {
{{cpp_class}}::~{{cpp_class}}() {}
+{{cpp_class}}::{{cpp_class}}(const {{cpp_class}}&) = default;
Yuki 2016/11/14 09:26:14 I don't know well about the windows-specific issue
bashi 2016/11/14 22:08:49 I had to write them in .cpp to avoid instanciation
+
+{{cpp_class}}& {{cpp_class}}::operator=(const {{cpp_class}}&) = default;
+
{% for member in members %}
bool {{cpp_class}}::{{member.has_method_name}}() const {
return {{member.has_method_expression}};

Powered by Google App Engine
This is Rietveld 408576698