third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl - Issue 2471393004: bindings: Use forward declarations for wrapper types in dictionary_impl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

Issue 2471393004: bindings: Use forward declarations for wrapper types in dictionary_impl (Closed)

Patch Set: Added copy operator Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl ('K') | « third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/tests/idls/core/TestDictionary.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl b/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

index f69a7bddf3bb496110998c938927a415c192790f..c6fc37799ce9cecec4abb573d682aa18d1b3c2c4 100644

--- a/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl

@@ -10,12 +10,18 @@

namespace blink {

+{% for decl in header_forward_decls %}

+class {{decl}};

+{% endfor %}

{# FIXME: Add "final" if this class doesn\'t have subclasses #}

class {{exported}}{{cpp_class}}{% if parent_cpp_class %} : public {{parent_cpp_class}}{% endif %} {

DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();

public:

{{cpp_class}}();

virtual ~{{cpp_class}}();

+ {{cpp_class}}(const {{cpp_class}}&);

+ {{cpp_class}}& operator=(const {{cpp_class}}&);

{% for member in members %}

bool {{member.has_method_name}}() const;