Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl

Issue 2471393004: bindings: Use forward declarations for wrapper types in dictionary_impl (Closed)
Patch Set: Added copy operator Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% filter format_blink_cpp_source_code %} 1 {% filter format_blink_cpp_source_code %}
2 2
3 {% include 'copyright_block.txt' %} 3 {% include 'copyright_block.txt' %}
4 #include "{{cpp_class}}.h" 4 #include "{{cpp_class}}.h"
5 5
6 {% for filename in cpp_includes %} 6 {% for filename in cpp_includes %}
7 #include "{{filename}}" 7 #include "{{filename}}"
8 {% endfor %} 8 {% endfor %}
9 9
10 namespace blink { 10 namespace blink {
11 11
12 {# Constructor #} 12 {# Constructor #}
13 {{cpp_class}}::{{cpp_class}}() { 13 {{cpp_class}}::{{cpp_class}}() {
14 {% for member in members if member.cpp_default_value %} 14 {% for member in members if member.cpp_default_value %}
15 {{member.setter_name}}({{member.cpp_default_value}}); 15 {{member.setter_name}}({{member.cpp_default_value}});
16 {% endfor %} 16 {% endfor %}
17 } 17 }
18 18
19 {{cpp_class}}::~{{cpp_class}}() {} 19 {{cpp_class}}::~{{cpp_class}}() {}
20 20
21 {{cpp_class}}::{{cpp_class}}(const {{cpp_class}}&) = default;
Yuki 2016/11/14 09:26:14 I don't know well about the windows-specific issue
bashi 2016/11/14 22:08:49 I had to write them in .cpp to avoid instanciation
22
23 {{cpp_class}}& {{cpp_class}}::operator=(const {{cpp_class}}&) = default;
24
21 {% for member in members %} 25 {% for member in members %}
22 bool {{cpp_class}}::{{member.has_method_name}}() const { 26 bool {{cpp_class}}::{{member.has_method_name}}() const {
23 return {{member.has_method_expression}}; 27 return {{member.has_method_expression}};
24 } 28 }
25 {{member.rvalue_cpp_type}} {{cpp_class}}::{{member.cpp_name}}() const { 29 {{member.rvalue_cpp_type}} {{cpp_class}}::{{member.cpp_name}}() const {
26 {% if member.nullable_indicator_name %} 30 {% if member.nullable_indicator_name %}
27 DCHECK({{member.nullable_indicator_name}}); 31 DCHECK({{member.nullable_indicator_name}});
28 {% endif %} 32 {% endif %}
29 return {{member.getter_expression}}; 33 return {{member.getter_expression}};
30 } 34 }
(...skipping 19 matching lines...) Expand all
50 visitor->trace(m_{{member.cpp_name}}); 54 visitor->trace(m_{{member.cpp_name}});
51 {% endfor %} 55 {% endfor %}
52 {% if parent_cpp_class %} 56 {% if parent_cpp_class %}
53 {{parent_cpp_class}}::trace(visitor); 57 {{parent_cpp_class}}::trace(visitor);
54 {% endif %} 58 {% endif %}
55 } 59 }
56 60
57 } // namespace blink 61 } // namespace blink
58 62
59 {% endfilter %}{# format_blink_cpp_source_code #} 63 {% endfilter %}{# format_blink_cpp_source_code #}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698