Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2471133007:
Remove wasCanceled() check in ImageLoader (Closed)
DescriptionRemove wasCanceled() check in ImageLoader
This CL removes a code block that seems unreachable, because errorOccurred()
should be always true if wasCanceled() is true.
BUG=667641
Committed: https://crrev.com/1e6d5389ff332f09924b180e4a114cbbec1435ce
Cr-Commit-Position: refs/heads/master@{#435364}
Patch Set 1 #Patch Set 2 : DCHECK #Messages
Total messages: 25 (16 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hiroshige@chromium.org changed reviewers: + yhirano@chromium.org
PTAL.
Is it good to place a DCHECK on Resource::setStatus?
Description was changed from ========== Remove wasCanceled() check in ImageLoader This CL removes a code block that seems unreachable, because errorOccurred() should be always true if wasCanceled() is true. BUG= ========== to ========== Remove wasCanceled() check in ImageLoader This CL removes a code block that seems unreachable, because errorOccurred() should be always true if wasCanceled() is true. BUG=667641 ==========
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/07 07:58:57, yhirano wrote: > Is it good to place a DCHECK on Resource::setStatus? Done. However, I'd like to remove reference to |resource->wasCanceled()| here. If the tests are not crashing at this DCHECK for a while, I'll remove this DCHECK when I split ImageResource into two parts in https://codereview.chromium.org/2469873002/.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by hiroshige@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480528571604490,
"parent_rev": "1ac068d82f0b25772c9b118622f886bd90fab90c", "commit_rev":
"995ad98c4dd7922ffcfdcc1b4847ad7c9dfa1ffd"}
Message was sent while issue was closed.
Description was changed from ========== Remove wasCanceled() check in ImageLoader This CL removes a code block that seems unreachable, because errorOccurred() should be always true if wasCanceled() is true. BUG=667641 ========== to ========== Remove wasCanceled() check in ImageLoader This CL removes a code block that seems unreachable, because errorOccurred() should be always true if wasCanceled() is true. BUG=667641 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove wasCanceled() check in ImageLoader This CL removes a code block that seems unreachable, because errorOccurred() should be always true if wasCanceled() is true. BUG=667641 ========== to ========== Remove wasCanceled() check in ImageLoader This CL removes a code block that seems unreachable, because errorOccurred() should be always true if wasCanceled() is true. BUG=667641 Committed: https://crrev.com/1e6d5389ff332f09924b180e4a114cbbec1435ce Cr-Commit-Position: refs/heads/master@{#435364} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1e6d5389ff332f09924b180e4a114cbbec1435ce Cr-Commit-Position: refs/heads/master@{#435364} |
