Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: third_party/WebKit/Source/core/loader/ImageLoader.cpp

Issue 2471133007: Remove wasCanceled() check in ImageLoader (Closed)
Patch Set: DCHECK Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/ImageLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/ImageLoader.cpp b/third_party/WebKit/Source/core/loader/ImageLoader.cpp
index 549c3b20dff7749f4978214743e5594a815d055a..4d70ac937abf3b1757641b4c55f1e99030f59d6b 100644
--- a/third_party/WebKit/Source/core/loader/ImageLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/ImageLoader.cpp
@@ -510,14 +510,7 @@ void ImageLoader::imageNotifyFinished(ImageResource* resource) {
updatedHasPendingEvent();
return;
}
- if (resource->wasCanceled()) {
- m_hasPendingLoadEvent = false;
- // Only consider updating the protection ref-count of the Element
- // immediately before returning from this function as doing so might result
- // in the destruction of this ImageLoader.
- updatedHasPendingEvent();
- return;
- }
+ DCHECK(!resource->wasCanceled());
loadEventSender().dispatchEventSoon(this);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698