Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2471043002: Allow icomplete types in scoped_refptr<T>. (Closed)

Created:
4 years, 1 month ago by DmitrySkiba
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, gavinp+memory_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow icomplete types in scoped_refptr<T>. This CL hides T::AddRef/Release calls behind a function that is only accessed during creation / pointer assignment. That allows passing around scoped_refptrs with incomplete (i.e. forwarded) types. The downsides are that scoped_refptr is now two pointers wide, and there is one more level of indirection when calling AddRef / Release.

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fixes #

Patch Set 4 : Release can delete this #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -54 lines) Patch
M base/memory/ref_counted.h View 1 2 3 4 chunks +49 lines, -38 lines 0 comments Download
M base/test/opaque_ref_counted.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M base/test/opaque_ref_counted.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M base/win/scoped_comptr.h View 1 2 4 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (17 generated)
DmitrySkiba
The CQ bit was checked by dskiba@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-01 23:38:27 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471043002/1
4 years, 1 month ago (2016-11-01 23:39:07 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-01 23:42:06 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/297809) mac_chromium_rel_ng on ...
4 years, 1 month ago (2016-11-01 23:42:07 UTC) #4
DmitrySkiba
The CQ bit was checked by dskiba@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-02 00:13:53 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471043002/20001
4 years, 1 month ago (2016-11-02 00:14:14 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-02 00:49:31 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/98840)
4 years, 1 month ago (2016-11-02 00:49:32 UTC) #8
DmitrySkiba
The CQ bit was checked by dskiba@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-02 02:09:37 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471043002/40001
4 years, 1 month ago (2016-11-02 02:09:53 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-02 02:52:46 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/98886)
4 years, 1 month ago (2016-11-02 02:52:47 UTC) #12
DmitrySkiba
The CQ bit was checked by dskiba@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-02 05:13:10 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2471043002/60001
4 years, 1 month ago (2016-11-02 05:13:25 UTC) #14
DmitrySkiba
Description was changed from ========== Allow icomplete types in scoped_refptr<T>. This CL hides T::AddRef/Release calls ...
4 years, 1 month ago (2016-11-02 06:20:18 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-02 07:15:55 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 07:15:57 UTC) #17
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698