Allow icomplete types in scoped_refptr<T>.

base/win/scoped_comptr.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_WIN_SCOPED_COMPTR_H_
 #define BASE_WIN_SCOPED_COMPTR_H_
 
 #include <unknwn.h>
 
 #include "base/logging.h"
@@ skipping 22 matching lines @@
   ScopedComPtr() {
   }
 
   explicit ScopedComPtr(Interface* p) : ParentClass(p) {
   }
 
   ScopedComPtr(const ScopedComPtr<Interface, interface_id>& p)
       : ParentClass(p) {
   }
 
-  ~ScopedComPtr() {
-    // We don't want the smart pointer class to be bigger than the pointer
-    // it wraps.
-    static_assert(
-        sizeof(ScopedComPtr<Interface, interface_id>) == sizeof(Interface*),
-        "ScopedComPtrSize");
-  }
-
   // Explicit Release() of the held object.  Useful for reuse of the
   // ScopedComPtr instance.
   // Note that this function equates to IUnknown::Release and should not
   // be confused with e.g. scoped_ptr::release().
   void Release() {
     if (this->ptr_ != NULL) {
       this->ptr_->Release();
       this->ptr_ = NULL;
     }
   }
 
   // Sets the internal pointer to NULL and returns the held object without
   // releasing the reference.
   Interface* Detach() {
     Interface* p = this->ptr_;
     this->ptr_ = NULL;
     return p;
   }
 
   // Accepts an interface pointer that has already been addref-ed.
   void Attach(Interface* p) {
     DCHECK(!this->ptr_);
+    this->ptr_caller_ = &ParentClass::PtrCallerImpl;
     this->ptr_ = p;
   }
 
   // Retrieves the pointer address.
   // Used to receive object pointers as out arguments (and take ownership).
   // The function DCHECKs on the current value being NULL.
   // Usage: Foo(p.Receive());
   Interface** Receive() {
     DCHECK(!this->ptr_) << "Object leak. Pointer must be NULL";
+    this->ptr_caller_ = &ParentClass::PtrCallerImpl;
     return &this->ptr_;
   }
 
   // A convenience for whenever a void pointer is needed as an out argument.
   void** ReceiveVoid() {
     return reinterpret_cast<void**>(Receive());
   }
 
   template <class Query>
   HRESULT QueryInterface(Query** p) {
@@ skipping 15 matching lines @@
   // Queries |other| for the interface this object wraps and returns the
   // error code from the other->QueryInterface operation.
   HRESULT QueryFrom(IUnknown* object) {
     DCHECK(object != NULL);
     return object->QueryInterface(Receive());
   }
 
   // Convenience wrapper around CoCreateInstance
   HRESULT CreateInstance(const CLSID& clsid, IUnknown* outer = NULL,
                          DWORD context = CLSCTX_ALL) {
-    DCHECK(!this->ptr_);
     HRESULT hr = ::CoCreateInstance(clsid, outer, context, *interface_id,
-                                    reinterpret_cast<void**>(&this->ptr_));
+                                    ReceiveVoid());
     return hr;
   }
 
   // Checks if the identity of |other| and this object is the same.
   bool IsSameObject(IUnknown* other) {
     if (!other && !this->ptr_)
       return true;
 
     if (!other || !this->ptr_)
       return false;
@@ skipping 29 matching lines @@
 
   static const IID& iid() {
     return *interface_id;
   }
 };
 
 }  // namespace win
 }  // namespace base
 
 #endif  // BASE_WIN_SCOPED_COMPTR_H_