Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2470793002: Revert of Use intersection observer to control frame throttling (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years, 1 month ago
Reviewers:
haraken, ojan, dgrogan, Sami, szager1
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, dgrogan, eae+blinkwatch, haraken, kinuko+watch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use intersection observer to control frame throttling (patchset #24 id:460001 of https://codereview.chromium.org/2272773002/ ) Reason for revert: Speculative revert to fix failures in fast/loader/open-in-srcdoc-unload.html Failed builds: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1345 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1346 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/1347 Error message: fast/loader/open-in-srcdoc-unload.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,3]})) Original issue's description: > Use intersection observer to control frame throttling > > This patch removes the FrameView-specific code for computing viewport > visibility in favor of registering an internal intersection observer. > > BUG=616519 > > Committed: https://crrev.com/5d3d4c00320aadad4a044dcb0241b86fc184b114 > Cr-Commit-Position: refs/heads/master@{#428984} TBR=ojan@chromium.org,dgrogan@chromium.org,haraken@chromium.org,szager@chromium.org,skyostil@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=616519 Committed: https://crrev.com/8036385ba33338a6ce38dc5ffc72fbbea12e79ae Cr-Commit-Position: refs/heads/master@{#429000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -212 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/activedomobject/media.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/activedomobject/media-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.h View 3 chunks +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 3 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 6 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 13 chunks +136 lines, -99 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGModelObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 4 chunks +2 lines, -56 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
please use gerrit instead
Created Revert of Use intersection observer to control frame throttling
4 years, 1 month ago (2016-11-01 14:39:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470793002/1
4 years, 1 month ago (2016-11-01 14:39:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 14:40:40 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8036385ba33338a6ce38dc5ffc72fbbea12e79ae Cr-Commit-Position: refs/heads/master@{#429000}
4 years, 1 month ago (2016-11-01 14:42:09 UTC) #7
please use gerrit instead
4 years, 1 month ago (2016-11-01 16:13:10 UTC) #8
Message was sent while issue was closed.
The bot is fixed. Speculation was correct.

Powered by Google App Engine
This is Rietveld 408576698