third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp - Issue 2470793002: Revert of Use intersection observer to control frame throttling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

Issue 2470793002: Revert of Use intersection observer to control frame throttling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ElementVisibilityObserver.h ('k') | third_party/WebKit/Source/core/dom/IntersectionObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

diff --git a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp b/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

index 8c4ecab9c24d74549216268dbf9a3f38e3310e9a..06769a487de85306bb853729c2cf2f6163d92347 100644

--- a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

+++ b/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

@@ -46,8 +46,6 @@

&document, WTF::bind(&ElementVisibilityObserver::onVisibilityChanged,

wrapWeakPersistent(this)));

DCHECK(m_intersectionObserver);

- m_intersectionObserver->setInitialState(

- IntersectionObserver::InitialState::kAuto);

m_intersectionObserver->observe(m_element.release());

}

@@ -63,10 +61,6 @@

m_intersectionObserver = nullptr;

}

-void ElementVisibilityObserver::deliverObservationsForTesting() {

- m_intersectionObserver->deliver();

DEFINE_TRACE(ElementVisibilityObserver) {

visitor->trace(m_element);

visitor->trace(m_intersectionObserver);