|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by xing.xu Modified:
4 years, 1 month ago CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, tfarina Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION
This fix is to align document title with FF(IE fails) and spec.
From the spec, "it must replace any sequence of one or more consecutive
space characters in that string with a single U+0020 SPACE character".
Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION
(tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE
RETURN (CR)".
U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION
are not listed and should be supported in title.
Note, for case fast/dom/Document/document-title-get.html there still exists
inconsistency among IE/FF(Win)/FF(Ubuntu).
IE: FAIL document.title should be one\u000b\u000c
space. Was one space.
FF(Win): FAIL document.title should be one\u000b\u000c
space. Was one\u000b space.
FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace.
Spec:
https://html.spec.whatwg.org/multipage/dom.html#document.title
https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse-whitespace
https://html.spec.whatwg.org/multipage/infrastructure.html#space-character
BUG=661859
TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html
Committed: https://crrev.com/e27088bd97ee3aecb9d04c56743c629a43b7f621
Cr-Commit-Position: refs/heads/master@{#430508}
Patch Set 1 #Patch Set 2 : fix dom test case #
Total comments: 1
Patch Set 3 : change magic number to named constants #Patch Set 4 : upload with --similarity=100 --no-find-copies #
Total comments: 1
Messages
Total messages: 47 (38 generated)
The CQ bit was checked by xing.xu@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xing.xu@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION Test case is from: http://w3c-test.org/html/dom/documents/dom-tree-accessors/document.title-05.html BUG=661859 ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)//FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
xing.xu@intel.com changed reviewers: + skobes@chromium.org
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)//FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)//FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)//FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
xing.xu@intel.com changed reviewers: + foolip@chromium.org
PTAL, thanks
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
I don't see the test case in the patch, and document.title-05-expected.txt gives me a Rietveld error. Possibly something wrong with the upload? https://codereview.chromium.org/2469983007/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/Document.cpp (right): https://codereview.chromium.org/2469983007/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/Document.cpp:1317: if ((c <= 0x20 && c != 0x0b) || c == 0x7F) { Can you use named constants for these instead of magic numbers? Also link to relevant spec in comments if possible.
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" are U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR). So LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" are U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR). So LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR / U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR / U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR / U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR / U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR / U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR / U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails). From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
The CQ bit was checked by xing.xu@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/03 14:31:41, skobes wrote: > I don't see the test case in the patch, and document.title-05-expected.txt gives > me a Rietveld error. Possibly something wrong with the upload? When click "view" links of document.title-05-expected.txt, will get "Bad content. Try to upload again". Even in patch set 3, this Bad content still happens. I found similarity issues like this, I didn't know what's happened: https://codereview.chromium.org/742293002#msg6(Zhang Lei fixed this) https://codereview.chromium.org/1887233004/#ps90001(Elliot Glaysher not fix this) https://codereview.chromium.org/27220005 And after rebase, nothing conflicts. Do you have any hints for this? > https://codereview.chromium.org/2469983007/diff/20001/third_party/WebKit/Sour... > File third_party/WebKit/Source/core/dom/Document.cpp (right): > > https://codereview.chromium.org/2469983007/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/core/dom/Document.cpp:1317: if ((c <= 0x20 && c != > 0x0b) || c == 0x7F) { > Can you use named constants for these instead of magic numbers? Also link to > relevant spec in comments if possible. Done.
The CQ bit was checked by xing.xu@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". So U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
lgtm (I filed http://crbug.com/663244 for the Rietveld error.)
The CQ bit was checked by xing.xu@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000cspace. Was one space. FF(Win): FAIL document.title should be one\u000b\u000cspace. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000c space. Was one space. FF(Win): FAIL document.title should be one\u000b\u000c space. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000c space. Was one space. FF(Win): FAIL document.title should be one\u000b\u000c space. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html ========== to ========== Fix document title with LINE SEPARATOR/PARAGRAPH SEPARATOR/LINE TABULATION This fix is to align document title with FF(IE fails) and spec. From the spec, "it must replace any sequence of one or more consecutive space characters in that string with a single U+0020 SPACE character". Here "space characters" refer to "U+0020 SPACE, U+0009 CHARACTER TABULATION (tab), U+000A LINE FEED (LF), U+000C FORM FEED (FF), and U+000D CARRIAGE RETURN (CR)". U+2028 LINE SEPARATOR/ U+2029 PARAGRAPH SEPARATOR/ U+000B LINE TABULATION are not listed and should be supported in title. Note, for case fast/dom/Document/document-title-get.html there still exists inconsistency among IE/FF(Win)/FF(Ubuntu). IE: FAIL document.title should be one\u000b\u000c space. Was one space. FF(Win): FAIL document.title should be one\u000b\u000c space. Was one\u000b space. FF(Ubuntu): FAIL document.title should be one\u000b space. Was one\u000b\u000cspace. Spec: https://html.spec.whatwg.org/multipage/dom.html#document.title https://html.spec.whatwg.org/multipage/infrastructure.html#strip-and-collapse... https://html.spec.whatwg.org/multipage/infrastructure.html#space-character BUG=661859 TEST=imported/wpt/html/dom/documents/dom-tree-accessors/document.title-05.html Committed: https://crrev.com/e27088bd97ee3aecb9d04c56743c629a43b7f621 Cr-Commit-Position: refs/heads/master@{#430508} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/e27088bd97ee3aecb9d04c56743c629a43b7f621 Cr-Commit-Position: refs/heads/master@{#430508}
Message was sent while issue was closed.
tkent@chromium.org changed reviewers: + tkent@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2469983007/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/dom/Document.cpp (right): https://codereview.chromium.org/2469983007/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/core/dom/Document.cpp:1316: const UChar lineTabulationCharacter = 0x0b; Please use symbols defined in wtf/text/CharacterNames.h. If it doesn't have these character names, please add them to it.
Message was sent while issue was closed.
On 2016/11/08 03:57:15, tkent wrote: > https://codereview.chromium.org/2469983007/diff/60001/third_party/WebKit/Sour... > File third_party/WebKit/Source/core/dom/Document.cpp (right): > > https://codereview.chromium.org/2469983007/diff/60001/third_party/WebKit/Sour... > third_party/WebKit/Source/core/dom/Document.cpp:1316: const UChar > lineTabulationCharacter = 0x0b; > Please use symbols defined in wtf/text/CharacterNames.h. If it doesn't have > these character names, please add them to it. Done by this: https://codereview.chromium.org/2476293003/ |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
