chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc - Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)

Patch Set: Touch ups. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h ('k') | chrome/browser/android/offline_pages/offline_page_bridge.h » ('j') | chrome/browser/android/offline_pages/offline_page_bridge.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

diff --git a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

index 66b371f74f8ba6a4648ebd69971600d71d60de13..57bb38afc9c5572e868e990b4499dc49be2ab06f 100644

--- a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

+++ b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

@@ -205,13 +205,6 @@ void OfflinePageEvaluationBridge::OfflinePageModelLoaded(

NotifyIfDoneLoading();

}

-void OfflinePageEvaluationBridge::OfflinePageModelChanged(

- OfflinePageModel* model) {}

-void OfflinePageEvaluationBridge::OfflinePageDeleted(

- int64_t offline_id,

- const ClientId& client_id) {}

// Implement RequestCoordinator::Observer

void OfflinePageEvaluationBridge::OnAdded(const SavePageRequest& request) {

JNIEnv* env = base::android::AttachCurrentThread();