Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)
Patch Set: Touch ups. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_bridge.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc
index 0c97c7e235f997cb8d532f076feffe2216901bb3..2aac4e81ffbd5d00da1d07fda524db6ac2fcfd32 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc
@@ -284,9 +284,13 @@ void OfflinePageBridge::OfflinePageModelLoaded(OfflinePageModel* model) {
NotifyIfDoneLoading();
}
-void OfflinePageBridge::OfflinePageModelChanged(OfflinePageModel* model) {
+void OfflinePageBridge::OfflinePageAdded(OfflinePageModel* model,
+ SavePageResult result,
+ const OfflinePageItem* item) {
DCHECK_EQ(offline_page_model_, model);
JNIEnv* env = base::android::AttachCurrentThread();
+
+ // TODO(dewittj): Change the Java side to use OfflinePageAdded.
Dmitry Titov 2016/11/02 07:15:37 Please make it next CL.
dewittj 2016/11/02 16:34:37 Acknowledged.
Java_OfflinePageBridge_offlinePageModelChanged(env, java_ref_);
}

Powered by Google App Engine
This is Rietveld 408576698