Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2469933002: Offline Pages: Replace Observer::OfflinePageModelChanged with OfflinePageAdded. (Closed)
Patch Set: Touch ups. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h" 5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h"
6 6
7 #include "base/android/callback_android.h" 7 #include "base/android/callback_android.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_string.h" 9 #include "base/android/jni_string.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 env, java_ref_); 198 env, java_ref_);
199 } 199 }
200 200
201 // Implement OfflinePageModel::Observer 201 // Implement OfflinePageModel::Observer
202 void OfflinePageEvaluationBridge::OfflinePageModelLoaded( 202 void OfflinePageEvaluationBridge::OfflinePageModelLoaded(
203 OfflinePageModel* model) { 203 OfflinePageModel* model) {
204 DCHECK_EQ(offline_page_model_, model); 204 DCHECK_EQ(offline_page_model_, model);
205 NotifyIfDoneLoading(); 205 NotifyIfDoneLoading();
206 } 206 }
207 207
208 void OfflinePageEvaluationBridge::OfflinePageModelChanged(
209 OfflinePageModel* model) {}
210
211 void OfflinePageEvaluationBridge::OfflinePageDeleted(
212 int64_t offline_id,
213 const ClientId& client_id) {}
214
215 // Implement RequestCoordinator::Observer 208 // Implement RequestCoordinator::Observer
216 void OfflinePageEvaluationBridge::OnAdded(const SavePageRequest& request) { 209 void OfflinePageEvaluationBridge::OnAdded(const SavePageRequest& request) {
217 JNIEnv* env = base::android::AttachCurrentThread(); 210 JNIEnv* env = base::android::AttachCurrentThread();
218 Java_OfflinePageEvaluationBridge_savePageRequestAdded( 211 Java_OfflinePageEvaluationBridge_savePageRequestAdded(
219 env, java_ref_, ToJavaSavePageRequest(env, request)); 212 env, java_ref_, ToJavaSavePageRequest(env, request));
220 } 213 }
221 214
222 void OfflinePageEvaluationBridge::OnCompleted( 215 void OfflinePageEvaluationBridge::OnCompleted(
223 const SavePageRequest& request, 216 const SavePageRequest& request,
224 RequestNotifier::BackgroundSavePageResult status) { 217 RequestNotifier::BackgroundSavePageResult status) {
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 276
284 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const { 277 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const {
285 if (!offline_page_model_->is_loaded()) 278 if (!offline_page_model_->is_loaded())
286 return; 279 return;
287 JNIEnv* env = base::android::AttachCurrentThread(); 280 JNIEnv* env = base::android::AttachCurrentThread();
288 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_); 281 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_);
289 } 282 }
290 283
291 } // namespace android 284 } // namespace android
292 } // namespace offline_pages 285 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698