Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2469483002: [InputEvent] Add prefixes 'history*' and 'format*' to |inputType| (Closed)

Created:
4 years, 1 month ago by chongz
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9, ojan
CC:
blink-reviews, blink-reviews-style_chromium.org, chaopeng, chromium-reviews, dtapuska
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[InputEvent] Add prefixes 'history*' and 'format*' to |inputType| Latest spec added prefixes 'history*' and 'format*' to |inputType|, this CL: 1. Updated implementation to match spec; 2. Cleaned unused / unsupported types. SPEC: https://w3c.github.io/input-events/index.html#h-interface-inputevent-attributes Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ BUG=652408 Committed: https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5 Cr-Commit-Position: refs/heads/master@{#430015}

Patch Set 1 : CL format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -127 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-execcommand.html View 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-keyboard.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 21 chunks +32 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UnlinkCommand.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UnlinkCommand.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.h View 2 chunks +18 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.cpp View 2 chunks +17 lines, -25 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
chongz
yosin@ PTAL, thanks!
4 years, 1 month ago (2016-10-31 22:33:42 UTC) #13
yosin_UTC9
lgtm Thanks for following the spec!
4 years, 1 month ago (2016-11-01 01:17:35 UTC) #16
chongz
ojan@ PTAL, thanks!
4 years, 1 month ago (2016-11-01 02:00:43 UTC) #18
ojan
lgtm
4 years, 1 month ago (2016-11-04 19:20:22 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469483002/20001
4 years, 1 month ago (2016-11-04 19:21:18 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-04 21:10:12 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 21:12:57 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5acaecd35b192852023d1be138e841c9c2c157c5
Cr-Commit-Position: refs/heads/master@{#430015}

Powered by Google App Engine
This is Rietveld 408576698