Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2469483002: [InputEvent] Add prefixes 'history*' and 'format*' to |inputType| (Closed)
Patch Set: CL format Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Editor.cpp
diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp
index 248dfca935316916b2151ec98532b2a1a4e1e3fb..5580120d035e1584143e3d28ef2aea646e356230 100644
--- a/third_party/WebKit/Source/core/editing/Editor.cpp
+++ b/third_party/WebKit/Source/core/editing/Editor.cpp
@@ -861,7 +861,7 @@ void Editor::unappliedEditing(EditCommandComposition* cmd) {
cmd->endingRootEditableElement());
dispatchInputEventEditableContentChanged(
cmd->startingRootEditableElement(), cmd->endingRootEditableElement(),
- InputEvent::InputType::Undo, nullAtom,
+ InputEvent::InputType::HistoryUndo, nullAtom,
InputEvent::EventIsComposing::NotComposing);
// TODO(editing-dev): The use of updateStyleAndLayoutIgnorePendingStylesheets
@@ -890,7 +890,7 @@ void Editor::reappliedEditing(EditCommandComposition* cmd) {
cmd->endingRootEditableElement());
dispatchInputEventEditableContentChanged(
cmd->startingRootEditableElement(), cmd->endingRootEditableElement(),
- InputEvent::InputType::Redo, nullAtom,
+ InputEvent::InputType::HistoryRedo, nullAtom,
InputEvent::EventIsComposing::NotComposing);
// TODO(yosin): Since |dispatchEditableContentChangedEvents()| and
@@ -1252,8 +1252,8 @@ void Editor::setBaseWritingDirection(WritingDirection direction) {
? "ltr"
: direction == RightToLeftWritingDirection ? "rtl" : "inherit",
false);
- applyParagraphStyleToSelection(style,
- InputEvent::InputType::SetWritingDirection);
+ applyParagraphStyleToSelection(
+ style, InputEvent::InputType::FormatSetBlockTextDirection);
}
void Editor::revealSelectionAfterEditingOperation(

Powered by Google App Engine
This is Rietveld 408576698