Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/core/events/InputEvent.h

Issue 2469483002: [InputEvent] Add prefixes 'history*' and 'format*' to |inputType| (Closed)
Patch Set: CL format Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/InputEvent.h
diff --git a/third_party/WebKit/Source/core/events/InputEvent.h b/third_party/WebKit/Source/core/events/InputEvent.h
index 8710e90b8c2d1582ec92c5ea89dff6f4ba2b56df..bdf4c98c56797fee05eeb9a85e8c730f5202a774 100644
--- a/third_party/WebKit/Source/core/events/InputEvent.h
+++ b/third_party/WebKit/Source/core/events/InputEvent.h
@@ -21,11 +21,11 @@ class InputEvent final : public UIEvent {
return new InputEvent(type, initializer);
}
+ // https://w3c.github.io/input-events/#h-interface-inputevent-attributes
enum class InputType {
None,
// Insertion.
InsertText,
- InsertNonText,
InsertLineBreak,
InsertParagraph,
InsertOrderedList,
@@ -44,34 +44,24 @@ class InputEvent final : public UIEvent {
DeleteContentForward,
DeleteByCut,
DeleteByDrag,
- // Command.
- Undo,
- Redo,
- // Styling.
- Bold,
- Italic,
- Underline,
- StrikeThrough,
- Superscript,
- Subscript,
+ // History.
+ HistoryUndo,
+ HistoryRedo,
// Formatting.
- JustifyCenter,
- JustifyRight,
- JustifyLeft,
- Indent,
- Outdent,
- RemoveFormat,
- // Not on spec.
- JustifyFull,
- SetColor,
- SetBackgroundColor,
- SetFont,
- ChangeAttributes,
- SetWritingDirection,
- Unscript,
- CreateLink,
- Unlink,
- FormatBlock,
+ FormatBold,
+ FormatItalic,
+ FormatUnderline,
+ FormatStrikeThrough,
+ FormatSuperscript,
+ FormatSubscript,
+ FormatJustifyCenter,
+ FormatJustifyFull,
+ FormatJustifyRight,
+ FormatJustifyLeft,
+ FormatIndent,
+ FormatOutdent,
+ FormatRemove,
+ FormatSetBlockTextDirection,
// Add new input types immediately above this line.
NumberOfInputTypes,

Powered by Google App Engine
This is Rietveld 408576698