Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 2469403005: Revert of [Tracing] Use TracingCategoryObserver in runtime statistics (Closed)

Created:
4 years, 1 month ago by lpy
Modified:
4 years, 1 month ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Tracing] Use TracingCategoryObserver in runtime statistics (patchset #6 id:140001 of https://codereview.chromium.org/2460973003/ ) Reason for revert: Static-Initializers failed on Ubuntu-12.04 Original issue's description: > [Tracing] Use TracingCategoryObserver in runtime statistics > > This patch is a follow-up patch to enable runtime statistics to use > TracingCategoryObserver. > > BUG=v8:5590 TBR=cbruni@chromium.org,fmeawad@chromium.org,alph@chromium.org,bmeurer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5590 Committed: https://crrev.com/5df5a28f2cd2f94ad26235ea19bf1005c162e72b Cr-Commit-Position: refs/heads/master@{#40743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -35 lines) Patch
M src/arguments.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/builtins/builtins-utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-tracer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/counters.h View 1 chunk +8 lines, -7 lines 0 comments Download
M src/counters.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/counters-inl.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/d8.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/gc-tracer.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M src/ic/handler-compiler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/log.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/tracing/trace-event.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/tracing/trace-event.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/tracing/tracing-category-observer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
lpy
Created Revert of [Tracing] Use TracingCategoryObserver in runtime statistics
4 years, 1 month ago (2016-11-03 23:10:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469403005/1
4 years, 1 month ago (2016-11-03 23:11:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 23:11:15 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:21:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5df5a28f2cd2f94ad26235ea19bf1005c162e72b
Cr-Commit-Position: refs/heads/master@{#40743}

Powered by Google App Engine
This is Rietveld 408576698