Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1618)

Side by Side Diff: src/builtins/builtins-utils.h

Issue 2469403005: Revert of [Tracing] Use TracingCategoryObserver in runtime statistics (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arguments.h ('k') | src/compiler-dispatcher/compiler-dispatcher-tracer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_BUILTINS_BUILTINS_UTILS_H_ 5 #ifndef V8_BUILTINS_BUILTINS_UTILS_H_
6 #define V8_BUILTINS_BUILTINS_UTILS_H_ 6 #define V8_BUILTINS_BUILTINS_UTILS_H_
7 7
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/base/logging.h" 9 #include "src/base/logging.h"
10 #include "src/builtins/builtins.h" 10 #include "src/builtins/builtins.h"
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 BuiltinArguments args(args_length, args_object); \ 84 BuiltinArguments args(args_length, args_object); \
85 RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::Builtin_##name); \ 85 RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::Builtin_##name); \
86 TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"), \ 86 TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.runtime"), \
87 "V8.Builtin_" #name); \ 87 "V8.Builtin_" #name); \
88 return Builtin_Impl_##name(args, isolate); \ 88 return Builtin_Impl_##name(args, isolate); \
89 } \ 89 } \
90 \ 90 \
91 MUST_USE_RESULT Object* Builtin_##name( \ 91 MUST_USE_RESULT Object* Builtin_##name( \
92 int args_length, Object** args_object, Isolate* isolate) { \ 92 int args_length, Object** args_object, Isolate* isolate) { \
93 DCHECK(isolate->context() == nullptr || isolate->context()->IsContext()); \ 93 DCHECK(isolate->context() == nullptr || isolate->context()->IsContext()); \
94 if (V8_UNLIKELY(FLAG_runtime_stats)) { \ 94 if (V8_UNLIKELY(TRACE_EVENT_RUNTIME_CALL_STATS_TRACING_ENABLED() || \
95 FLAG_runtime_call_stats)) { \
95 return Builtin_Impl_Stats_##name(args_length, args_object, isolate); \ 96 return Builtin_Impl_Stats_##name(args_length, args_object, isolate); \
96 } \ 97 } \
97 BuiltinArguments args(args_length, args_object); \ 98 BuiltinArguments args(args_length, args_object); \
98 return Builtin_Impl_##name(args, isolate); \ 99 return Builtin_Impl_##name(args, isolate); \
99 } \ 100 } \
100 \ 101 \
101 MUST_USE_RESULT static Object* Builtin_Impl_##name(BuiltinArguments args, \ 102 MUST_USE_RESULT static Object* Builtin_Impl_##name(BuiltinArguments args, \
102 Isolate* isolate) 103 Isolate* isolate)
103 104
104 // ---------------------------------------------------------------------------- 105 // ----------------------------------------------------------------------------
(...skipping 20 matching lines...) Expand all
125 isolate->factory()->NewStringFromAsciiChecked(method))); \ 126 isolate->factory()->NewStringFromAsciiChecked(method))); \
126 } \ 127 } \
127 Handle<String> name; \ 128 Handle<String> name; \
128 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( \ 129 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( \
129 isolate, name, Object::ToString(isolate, args.receiver())) 130 isolate, name, Object::ToString(isolate, args.receiver()))
130 131
131 } // namespace internal 132 } // namespace internal
132 } // namespace v8 133 } // namespace v8
133 134
134 #endif // V8_BUILTINS_BUILTINS_UTILS_H_ 135 #endif // V8_BUILTINS_BUILTINS_UTILS_H_
OLDNEW
« no previous file with comments | « src/arguments.h ('k') | src/compiler-dispatcher/compiler-dispatcher-tracer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698