Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: src/tracing/tracing-category-observer.cc

Issue 2469403005: Revert of [Tracing] Use TracingCategoryObserver in runtime statistics (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/tracing/trace-event.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/tracing/tracing-category-observer.h" 5 #include "src/tracing/tracing-category-observer.h"
6 6
7 #include "src/flags.h" 7 #include "src/flags.h"
8 #include "src/tracing/trace-event.h" 8 #include "src/tracing/trace-event.h"
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace tracing { 12 namespace tracing {
13 13
14 TracingCategoryObserver* TracingCategoryObserver::instance_ = nullptr; 14 TracingCategoryObserver* TracingCategoryObserver::instance_ = nullptr;
15 15
16 void TracingCategoryObserver::SetUp() { 16 void TracingCategoryObserver::SetUp() {
17 TracingCategoryObserver::instance_ = new TracingCategoryObserver(); 17 TracingCategoryObserver::instance_ = new TracingCategoryObserver();
18 v8::internal::V8::GetCurrentPlatform()->AddTraceStateObserver( 18 v8::internal::V8::GetCurrentPlatform()->AddTraceStateObserver(
19 TracingCategoryObserver::instance_); 19 TracingCategoryObserver::instance_);
20 TRACE_EVENT_WARMUP_CATEGORY(TRACE_DISABLED_BY_DEFAULT("v8.runtime_stats"));
21 } 20 }
22 21
23 void TracingCategoryObserver::TearDown() { 22 void TracingCategoryObserver::TearDown() {
24 v8::internal::V8::GetCurrentPlatform()->RemoveTraceStateObserver( 23 v8::internal::V8::GetCurrentPlatform()->RemoveTraceStateObserver(
25 TracingCategoryObserver::instance_); 24 TracingCategoryObserver::instance_);
26 delete TracingCategoryObserver::instance_; 25 delete TracingCategoryObserver::instance_;
27 } 26 }
28 27
29 void TracingCategoryObserver::OnTraceEnabled() { 28 void TracingCategoryObserver::OnTraceEnabled() {
30 bool enabled = false; 29 bool enabled = false;
31 TRACE_EVENT_CATEGORY_GROUP_ENABLED( 30 TRACE_EVENT_CATEGORY_GROUP_ENABLED(
32 TRACE_DISABLED_BY_DEFAULT("v8.runtime_stats"), &enabled); 31 TRACE_DISABLED_BY_DEFAULT("v8.runtime_stats"), &enabled);
33 if (enabled) { 32 if (enabled) {
34 v8::internal::FLAG_runtime_stats |= ENABLED_BY_TRACING; 33 v8::internal::FLAG_runtime_stats |= ENABLED_BY_TRACING;
35 } 34 }
36 } 35 }
37 36
38 void TracingCategoryObserver::OnTraceDisabled() { 37 void TracingCategoryObserver::OnTraceDisabled() {
39 v8::internal::FLAG_runtime_stats &= ~ENABLED_BY_TRACING; 38 v8::internal::FLAG_runtime_stats &= ~ENABLED_BY_TRACING;
40 } 39 }
41 40
42 } // namespace tracing 41 } // namespace tracing
43 } // namespace v8 42 } // namespace v8
OLDNEW
« no previous file with comments | « src/tracing/trace-event.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698