Clean up source_site_instance usage in Navigator::RequestOpenURL.

content/browser/frame_host/render_frame_host_impl.h

Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index f0d8d06376d69286e96bfca5db50aa2f39ee9ff3..50788c819c0d5ae43a89a14f32bc41080d5e6a10 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -375,14 +375,10 @@ class CONTENT_EXPORT RenderFrameHostImpl
   // Navigates to an interstitial page represented by the provided data URL.
   void NavigateToInterstitialURL(const GURL& data_url);
 
-  // Treat this prospective navigation as though it originated from the frame.
-  // Used, e.g., for a navigation request that originated from a RemoteFrame.
-  // |source_site_instance| is the SiteInstance of the frame that initiated the
-  // navigation.
-  // TODO(creis): Remove this method and have RenderFrameProxyHost call

[Charlie Reis, 2016/11/02 17:05:37]

Interesting-- I guess this evolved to be the default way to get to
RequestOpenURL instead.  Thanks for cleaning up the comment.

[alexmos, 2016/11/03 06:03:01]

Comment is now gone after I combined this with OnOpenURL. :)  Most of it is now
in the comment on setting source_site_instance in RequestOpenURL, but let me
know if there's a better place for it.

-  // RequestOpenURL with its FrameTreeNode.
-  void OpenURL(const FrameHostMsg_OpenURL_Params& params,
-               SiteInstance* source_site_instance);
+  // Starts a new navigation.  This navigation can originate from any frame in
+  // this frame's SiteInstance.  Note that navigations on RenderFrameProxies do
+  // not use this and go through RequestTransferURL instead.
+  void OpenURL(const FrameHostMsg_OpenURL_Params& params);
 
   // Stop the load in progress.
   void Stop();