Clean up source_site_instance usage in Navigator::RequestOpenURL.

content/browser/frame_host/navigator_impl.cc

Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 56fc3923eef3ab6f566b9fc665a863c1872671d5..19a77cb3969192f8c045365957b4729ee32820b6 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -713,7 +713,6 @@ void NavigatorImpl::RequestOpenURL(
     bool uses_post,
     const scoped_refptr<ResourceRequestBodyImpl>& body,
     const std::string& extra_headers,
-    SiteInstance* source_site_instance,
     const Referrer& referrer,
     WindowOpenDisposition disposition,
     bool should_replace_current_entry,
@@ -762,7 +761,7 @@ void NavigatorImpl::RequestOpenURL(
   params.uses_post = uses_post;
   params.post_data = body;
   params.extra_headers = extra_headers;
-  params.source_site_instance = source_site_instance;
+  params.source_site_instance = current_site_instance;

[Charlie Reis, 2016/11/02 17:05:36]

Let's put a comment on this, saying that only same-SiteInstance frames can reach
here, since RequestOpenURL is only used for local frames.  (This matters both if
we ever go back to using RequestOpenURL in RenderFrameProxy, or if we someday
decide to avoid frame tree duplication when multiple SiteInstances share the
same process.)

[alexmos, 2016/11/03 06:03:01]

Done.

   if (redirect_chain.size() > 0)
     params.redirect_chain = redirect_chain;
   params.should_replace_current_entry = should_replace_current_entry;