Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2469143002: Make siblingRules and uncommonAttributeRules private. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years, 1 month ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make siblingRules and uncommonAttributeRules private. These vectors only need to be modified inside the RuleFeatureSet class. Added methods for const access. R=meade@chromium.org Committed: https://crrev.com/3e8fb22d9bf0440d722fa95cdbe9a1d2265c17a5 Cr-Commit-Position: refs/heads/master@{#429220}

Patch Set 1 #

Patch Set 2 : Compile fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -23 lines) Patch
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSGlobalRuleSet.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.h View 4 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 3 chunks +13 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinderTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
rune
ptal
4 years, 1 month ago (2016-11-01 23:31:23 UTC) #7
meade_UTC10
lgtm
4 years, 1 month ago (2016-11-02 01:58:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469143002/20001
4 years, 1 month ago (2016-11-02 06:07:33 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 06:12:16 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 06:15:11 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e8fb22d9bf0440d722fa95cdbe9a1d2265c17a5
Cr-Commit-Position: refs/heads/master@{#429220}

Powered by Google App Engine
This is Rietveld 408576698