Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: third_party/WebKit/Source/core/css/RuleFeature.cpp

Issue 2469143002: Make siblingRules and uncommonAttributeRules private. (Closed)
Patch Set: Compile fixes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/RuleFeature.cpp
diff --git a/third_party/WebKit/Source/core/css/RuleFeature.cpp b/third_party/WebKit/Source/core/css/RuleFeature.cpp
index b9d4daa1efe1f7bc622c6e73c73a854ed7fb735f..bf25792efe37981533bf22f1ffadae754ad9a680 100644
--- a/third_party/WebKit/Source/core/css/RuleFeature.cpp
+++ b/third_party/WebKit/Source/core/css/RuleFeature.cpp
@@ -791,13 +791,15 @@ RuleFeatureSet::SelectorPreMatch RuleFeatureSet::collectFeaturesFromRuleData(
m_metadata.add(metadata);
- if (metadata.foundSiblingSelector)
- siblingRules.append(RuleFeature(ruleData.rule(), ruleData.selectorIndex(),
- ruleData.hasDocumentSecurityOrigin()));
- if (ruleData.containsUncommonAttributeSelector())
- uncommonAttributeRules.append(
+ if (metadata.foundSiblingSelector) {
+ m_siblingRules.append(RuleFeature(ruleData.rule(), ruleData.selectorIndex(),
+ ruleData.hasDocumentSecurityOrigin()));
+ }
+ if (ruleData.containsUncommonAttributeSelector()) {
+ m_uncommonAttributeRules.append(
RuleFeature(ruleData.rule(), ruleData.selectorIndex(),
ruleData.hasDocumentSecurityOrigin()));
+ }
updateInvalidationSets(ruleData);
return SelectorMayMatch;
@@ -924,14 +926,14 @@ void RuleFeatureSet::add(const RuleFeatureSet& other) {
m_metadata.add(other.m_metadata);
- siblingRules.appendVector(other.siblingRules);
- uncommonAttributeRules.appendVector(other.uncommonAttributeRules);
+ m_siblingRules.appendVector(other.m_siblingRules);
+ m_uncommonAttributeRules.appendVector(other.m_uncommonAttributeRules);
}
void RuleFeatureSet::clear() {
RELEASE_ASSERT(m_isAlive);
- siblingRules.clear();
- uncommonAttributeRules.clear();
+ m_siblingRules.clear();
+ m_uncommonAttributeRules.clear();
m_metadata.clear();
m_classInvalidationSets.clear();
m_attributeInvalidationSets.clear();
@@ -1156,8 +1158,8 @@ void RuleFeatureSet::addFeaturesToUniversalSiblingInvalidationSet(
}
DEFINE_TRACE(RuleFeatureSet) {
- visitor->trace(siblingRules);
- visitor->trace(uncommonAttributeRules);
+ visitor->trace(m_siblingRules);
+ visitor->trace(m_uncommonAttributeRules);
}
void RuleFeatureSet::InvalidationSetFeatures::add(
« no previous file with comments | « third_party/WebKit/Source/core/css/RuleFeature.h ('k') | third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698