Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: third_party/WebKit/Source/core/css/RuleFeature.h

Issue 2469143002: Make siblingRules and uncommonAttributeRules private. (Closed)
Patch Set: Compile fixes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/RuleFeature.h
diff --git a/third_party/WebKit/Source/core/css/RuleFeature.h b/third_party/WebKit/Source/core/css/RuleFeature.h
index 2f4e20e0302a43f97a9934d7a7cb76738e6e6a21..3f3f1592fb225b4a894a81eae2442d646080aafe 100644
--- a/third_party/WebKit/Source/core/css/RuleFeature.h
+++ b/third_party/WebKit/Source/core/css/RuleFeature.h
@@ -76,7 +76,7 @@ class CORE_EXPORT RuleFeatureSet {
SelectorPreMatch collectFeaturesFromRuleData(const RuleData&);
- bool usesSiblingRules() const { return !siblingRules.isEmpty(); }
+ bool usesSiblingRules() const { return !m_siblingRules.isEmpty(); }
bool usesFirstLineRules() const { return m_metadata.usesFirstLineRules; }
bool usesWindowInactiveSelector() const {
return m_metadata.usesWindowInactiveSelector;
@@ -103,6 +103,11 @@ class CORE_EXPORT RuleFeatureSet {
return m_idInvalidationSets.contains(idValue);
}
+ const HeapVector<RuleFeature>& siblingRules() const { return m_siblingRules; }
+ const HeapVector<RuleFeature>& uncommonAttributeRules() const {
+ return m_uncommonAttributeRules;
+ }
+
// Collect descendant and sibling invalidation sets.
void collectInvalidationSetsForClass(InvalidationLists&,
Element&,
@@ -139,9 +144,6 @@ class CORE_EXPORT RuleFeatureSet {
DECLARE_TRACE();
- HeapVector<RuleFeature> siblingRules;
- HeapVector<RuleFeature> uncommonAttributeRules;
-
bool isAlive() const { return m_isAlive; }
protected:
@@ -273,6 +275,8 @@ class CORE_EXPORT RuleFeatureSet {
PseudoTypeInvalidationSetMap m_pseudoInvalidationSets;
RefPtr<SiblingInvalidationSet> m_universalSiblingInvalidationSet;
RefPtr<DescendantInvalidationSet> m_nthInvalidationSet;
+ HeapVector<RuleFeature> m_siblingRules;
+ HeapVector<RuleFeature> m_uncommonAttributeRules;
// If true, the RuleFeatureSet is alive and can be used.
unsigned m_isAlive : 1;
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSGlobalRuleSet.cpp ('k') | third_party/WebKit/Source/core/css/RuleFeature.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698