Issue 246883004: Fix checkValidity for form containing menulist select

Issue 246883004: Fix checkValidity for form containing menulist select (Closed)

Created:
6 years, 8 months ago by gnana

Modified:
6 years, 8 months ago

Reviewers:
tkent, keishi

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org, ojan

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix checkValidity for form containing menulist select checkvalidity for form returns false when we select the option from menulist. This happens because setNeedsValidityCheck() is called after dispatchInputAndChangeEventForMenuList() is called. Moved the setNeedsValidityCheck() before dispatchInputAndChangeEventForMenuList(). BUG=360444 TEST=fast/forms/checkValidity-select-form.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172386

Patch Set 1 : #

Total comments: 6

Patch Set 2 : incorporated review comments #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -4 lines)			Patch
A	LayoutTests/fast/forms/checkValidity-select-form.html	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/forms/checkValidity-select-form-expected.txt	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.cpp	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/246883004/diff/20001/LayoutTests/fast/forms/checkValidity-005.html File LayoutTests/fast/forms/checkValidity-005.html (right): https://codereview.chromium.org/246883004/diff/20001/LayoutTests/fast/forms/checkValidity-005.html#newcode1 LayoutTests/fast/forms/checkValidity-005.html:1: <html> The test file name is bad. -005 is ...

6 years, 8 months ago (2014-04-23 07:37:35 UTC) #3

gnana

Please have a look. https://codereview.chromium.org/246883004/diff/20001/LayoutTests/fast/forms/checkValidity-005.html File LayoutTests/fast/forms/checkValidity-005.html (right): https://codereview.chromium.org/246883004/diff/20001/LayoutTests/fast/forms/checkValidity-005.html#newcode1 LayoutTests/fast/forms/checkValidity-005.html:1: <html> On 2014/04/23 07:37:35, tkent ...

6 years, 8 months ago (2014-04-23 14:10:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gnanasekar.s@samsung.com/246883004/40001

6 years, 8 months ago (2014-04-23 14:35:26 UTC) #6

Message was sent while issue was closed.

Change committed as 172386

Expand Messages | Collapse Messages